From b4e3d2935836b0e299815773b14afc9c3d74c489 Mon Sep 17 00:00:00 2001 From: Tim Beatty Date: Thu, 30 Jun 2016 15:00:17 -0300 Subject: [PATCH] Updated BlobReadChannel to prevent integer overflow when reading large blobs --- .../java/com/google/cloud/storage/BlobReadChannel.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcloud-java-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java b/gcloud-java-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java index 0352e8a9d550..d84683843acc 100644 --- a/gcloud-java-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java +++ b/gcloud-java-storage/src/main/java/com/google/cloud/storage/BlobReadChannel.java @@ -45,7 +45,7 @@ class BlobReadChannel implements ReadChannel { private final BlobId blob; private final Map requestOptions; private String lastEtag; - private int position; + private long position; private boolean isOpen; private boolean endOfStream; private int chunkSize = DEFAULT_CHUNK_SIZE; @@ -164,7 +164,7 @@ static class StateImpl implements RestorableState, Serializable { private final BlobId blob; private final Map requestOptions; private final String lastEtag; - private final int position; + private final long position; private final boolean isOpen; private final boolean endOfStream; private final int chunkSize; @@ -185,7 +185,7 @@ static class Builder { private final BlobId blob; private final Map requestOptions; private String lastEtag; - private int position; + private long position; private boolean isOpen; private boolean endOfStream; private int chunkSize; @@ -201,7 +201,7 @@ Builder lastEtag(String lastEtag) { return this; } - Builder position(int position) { + Builder position(long position) { this.position = position; return this; }