diff --git a/README.md b/README.md index 3bc2219ab2bd..58044d675a8a 100644 --- a/README.md +++ b/README.md @@ -601,14 +601,14 @@ import com.google.cloud.translate.Translation; Translate translate = TranslateOptions.defaultInstance().service(); Detection detection = translate.detect("Hola"); -String detectedLanguage = detection.language(); +String detectedLanguage = detection.getLanguage(); Translation translation = translate.translate( "World", TranslateOption.sourceLanguage("en"), TranslateOption.targetLanguage(detectedLanguage)); -System.out.printf("Hola %s%n", translation.translatedText()); +System.out.printf("Hola %s%n", translation.getTranslatedText()); ``` Troubleshooting diff --git a/TESTING.md b/TESTING.md index b6a3b68082bb..249936c1cf0b 100644 --- a/TESTING.md +++ b/TESTING.md @@ -285,7 +285,7 @@ key. that uses the `RemoteTranslateHelper` to list supported languages. ```java RemoteTranslateHelper translateHelper = RemoteTranslateHelper.create(PROJECT_ID, API_KEY); - Translate translate = translateHelper.options().service(); + Translate translate = translateHelper.getOptions().service(); List languages = translate.listSupportedLanguages(); ``` diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/translate/snippets/DetectLanguageAndTranslate.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/translate/snippets/DetectLanguageAndTranslate.java index 994ff40852fe..e66921e60ace 100644 --- a/google-cloud-examples/src/main/java/com/google/cloud/examples/translate/snippets/DetectLanguageAndTranslate.java +++ b/google-cloud-examples/src/main/java/com/google/cloud/examples/translate/snippets/DetectLanguageAndTranslate.java @@ -41,7 +41,7 @@ public static void main(String... args) { // Detect the language of some text Detection detection = translate.detect("Hola"); - String detectedLanguage = detection.language(); + String detectedLanguage = detection.getLanguage(); // Translate some text Translation translation = translate.translate( @@ -49,6 +49,6 @@ public static void main(String... args) { TranslateOption.sourceLanguage("en"), TranslateOption.targetLanguage(detectedLanguage)); - System.out.printf("Hola %s%n", translation.translatedText()); + System.out.printf("Hola %s%n", translation.getTranslatedText()); } } diff --git a/google-cloud-examples/src/test/java/com/google/cloud/examples/translate/snippets/ITTranslateSnippets.java b/google-cloud-examples/src/test/java/com/google/cloud/examples/translate/snippets/ITTranslateSnippets.java index 0aaaa2952772..2fe45d2147e9 100644 --- a/google-cloud-examples/src/test/java/com/google/cloud/examples/translate/snippets/ITTranslateSnippets.java +++ b/google-cloud-examples/src/test/java/com/google/cloud/examples/translate/snippets/ITTranslateSnippets.java @@ -47,7 +47,7 @@ public class ITTranslateSnippets { @BeforeClass public static void beforeClass() { RemoteTranslateHelper helper = RemoteTranslateHelper.create(); - translateSnippets = new TranslateSnippets(helper.options().service()); + translateSnippets = new TranslateSnippets(helper.getOptions().service()); } @Test @@ -55,8 +55,8 @@ public void testListSupportedLanguages() { Set supportedLanguages = new HashSet<>(); List languages = translateSnippets.listSupportedLanguages(); for (Language language : languages) { - supportedLanguages.add(language.code()); - assertNotNull(language.name()); + supportedLanguages.add(language.getCode()); + assertNotNull(language.getName()); } for (String code : LANGUAGES) { assertTrue(supportedLanguages.contains(code)); @@ -68,8 +68,8 @@ public void testListSupportedLanguagesWithTarget() { Set supportedLanguages = new HashSet<>(); List languages = translateSnippets.listSupportedLanguagesWithTarget(); for (Language language : languages) { - supportedLanguages.add(language.code()); - assertNotNull(language.name()); + supportedLanguages.add(language.getCode()); + assertNotNull(language.getName()); } for (String code : LANGUAGES) { assertTrue(supportedLanguages.contains(code)); @@ -80,48 +80,48 @@ public void testListSupportedLanguagesWithTarget() { public void testDetectLanguageOfTexts() { List detections = translateSnippets.detectLanguageOfTexts(); Detection detection = detections.get(0); - assertEquals("en", detection.language()); + assertEquals("en", detection.getLanguage()); detection = detections.get(1); - assertEquals("es", detection.language()); + assertEquals("es", detection.getLanguage()); } @Test public void testDetectLanguageOfTextList() { List detections = translateSnippets.detectLanguageOfTextList(); Detection detection = detections.get(0); - assertEquals("en", detection.language()); + assertEquals("en", detection.getLanguage()); detection = detections.get(1); - assertEquals("es", detection.language()); + assertEquals("es", detection.getLanguage()); } @Test public void testDetectLanguageOfText() { Detection detection = translateSnippets.detectLanguageOfText(); - assertEquals("en", detection.language()); + assertEquals("en", detection.getLanguage()); } @Test public void testTranslateTextList() { List translations = translateSnippets.translateTexts(); Translation translation = translations.get(0); - assertEquals("Hello, World!", translation.translatedText()); - assertEquals("en", translation.sourceLanguage()); + assertEquals("Hello, World!", translation.getTranslatedText()); + assertEquals("en", translation.getSourceLanguage()); translation = translations.get(1); - assertEquals("Hello World!", translation.translatedText()); - assertEquals("es", translation.sourceLanguage()); + assertEquals("Hello World!", translation.getTranslatedText()); + assertEquals("es", translation.getSourceLanguage()); } @Test public void testTranslateText() { Translation translation = translateSnippets.translateText(); - assertEquals("Hello World!", translation.translatedText()); - assertEquals("es", translation.sourceLanguage()); + assertEquals("Hello World!", translation.getTranslatedText()); + assertEquals("es", translation.getSourceLanguage()); } @Test public void testTranslateTextWithOptions() { Translation translation = translateSnippets.translateTextWithOptions(); - assertEquals("Hallo Welt!", translation.translatedText()); - assertEquals("es", translation.sourceLanguage()); + assertEquals("Hallo Welt!", translation.getTranslatedText()); + assertEquals("es", translation.getSourceLanguage()); } } diff --git a/google-cloud-translate/README.md b/google-cloud-translate/README.md index a1d6237049c4..1d51871eb550 100644 --- a/google-cloud-translate/README.md +++ b/google-cloud-translate/README.md @@ -104,7 +104,7 @@ import com.google.cloud.translate.Detection; Then add the following code to detect the text's language: ```java -String detectedLanguage = detection.language(); +String detectedLanguage = detection.getLanguage(); ``` #### Translating text diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/Detection.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/Detection.java index 8b924e5e9173..9157ca2cb9ff 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/Detection.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/Detection.java @@ -47,7 +47,18 @@ private Detection(String language, Float confidence) { * @see * Supported Languages */ + @Deprecated public String language() { + return getLanguage(); + } + + /** + * Returns the code of the detected language. + * + * @see + * Supported Languages + */ + public String getLanguage() { return language; } @@ -56,7 +67,17 @@ public String language() { * higher the confidence level for the language detection. Note that this value is not always * available. */ + @Deprecated public float confidence() { + return getConfidence(); + } + + /** + * Returns an optional confidence value in the interval [0,1]. The closer this value is to 1, the + * higher the confidence level for the language detection. Note that this value is not always + * available. + */ + public float getConfidence() { return confidence; } diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/Language.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/Language.java index 4847b5ebb540..6a8b99b8a07f 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/Language.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/Language.java @@ -54,14 +54,30 @@ private Language(String code, String name) { /** * Returns the code of the language. */ + @Deprecated public String code() { + return getCode(); + } + + /** + * Returns the code of the language. + */ + public String getCode() { return code; } /** * Returns the name of the language. */ + @Deprecated public String name() { + return getName(); + } + + /** + * Returns the name of the language. + */ + public String getName() { return name; } diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/Option.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/Option.java index 7fc05678e39e..7c9ff11d7849 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/Option.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/Option.java @@ -39,11 +39,11 @@ abstract class Option implements Serializable { this.value = value; } - TranslateRpc.Option rpcOption() { + TranslateRpc.Option getRpcOption() { return rpcOption; } - Object value() { + Object getValue() { return value; } diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/Translate.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/Translate.java index 57f3a4a1137d..0bad2b22e1a9 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/Translate.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/Translate.java @@ -85,9 +85,9 @@ public static TranslateOption targetLanguage(String targetLanguage) { /** * Returns the list of languages supported by Google Translate. If - * {@link LanguageListOption#targetLanguage(String)} is provided, {@link Language#name()} values - * are localized according to the provided target language. If no such option is passed, - * {@link Language#name()} values are localized according to + * {@link LanguageListOption#targetLanguage(String)} is provided, {@link Language#getName()} + * values are localized according to the provided target language. If no such option is passed, + * {@link Language#getName()} values are localized according to * {@link TranslateOptions#targetLanguage()}. * *

Example of listing supported languages, localized according to diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/TranslateImpl.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/TranslateImpl.java index 3d02ac898660..da49b20da3f6 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/TranslateImpl.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/TranslateImpl.java @@ -126,7 +126,7 @@ public Translation translate(String text, TranslateOption... options) { private Map optionMap(Option... options) { Map optionMap = Maps.newEnumMap(TranslateRpc.Option.class); for (Option option : options) { - Object prev = optionMap.put(option.rpcOption(), option.value()); + Object prev = optionMap.put(option.getRpcOption(), option.getValue()); checkArgument(prev == null, "Duplicate option %s", option); } return optionMap; diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java index ebf9db4835a2..fa79635a4a94 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/Translation.java @@ -52,15 +52,32 @@ private Translation(String translatedText, String sourceLanguage) { /** * Returns the translated text. */ + @Deprecated public String translatedText() { return translatedText; } + /** + * Returns the translated text. + */ + public String getTranslatedText() { + return translatedText; + } + /** * Returns the language code of the source text. If no source language was provided this value is * the source language as detected by the Google Translate service. */ + @Deprecated public String sourceLanguage() { + return getSourceLanguage(); + } + + /** + * Returns the language code of the source text. If no source language was provided this value is + * the source language as detected by the Google Translate service. + */ + public String getSourceLanguage() { return sourceLanguage; } diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/package-info.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/package-info.java index 4d417914a89a..cb022c5cb53e 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/package-info.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/package-info.java @@ -28,14 +28,14 @@ * Translate translate = TranslateOptions.defaultInstance().service(); * * Detection detection = translate.detect("Hola"); - * String detectedLanguage = detection.language(); + * String detectedLanguage = detection.getLanguage(); * * Translation translation = translate.translate( * "World", * TranslateOption.sourceLanguage("en"), * TranslateOption.targetLanguage(detectedLanguage)); * - * System.out.printf("Hola %s%n", translation.translatedText()); + * System.out.printf("Hola %s%n", translation.getTranslatedText()); * } */ package com.google.cloud.translate; diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/RemoteTranslateHelper.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/RemoteTranslateHelper.java index a903d08ddb9b..6afe5c58d615 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/RemoteTranslateHelper.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/RemoteTranslateHelper.java @@ -21,7 +21,7 @@ /** * Utility to create a remote translate configuration for testing. Translate options can be obtained - * via the {@link #options()} method. Returned options have custom + * via the {@link #getOptions()} method. Returned options have custom * {@link TranslateOptions#retryParams()}: {@link RetryParams#retryMaxAttempts()} is {@code 10}, * {@link RetryParams#retryMinAttempts()} is {@code 6}, {@link RetryParams#maxRetryDelayMillis()} * is {@code 30000}, {@link RetryParams#totalRetryPeriodMillis()} is {@code 120000} and @@ -40,7 +40,15 @@ private RemoteTranslateHelper(TranslateOptions options) { /** * Returns a {@link TranslateOptions} object to be used for testing. */ + @Deprecated public TranslateOptions options() { + return getOptions(); + } + + /** + * Returns a {@link TranslateOptions} object to be used for testing. + */ + public TranslateOptions getOptions() { return options; } diff --git a/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/package-info.java b/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/package-info.java index 317b7f71e493..d919feb87335 100644 --- a/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/package-info.java +++ b/google-cloud-translate/src/main/java/com/google/cloud/translate/testing/package-info.java @@ -21,7 +21,7 @@ *

Before the test: *

 {@code
  * RemoteTranslateHelper helper = RemoteTranslateHelper.create();
- * Translate translate = helper.options().service();
+ * Translate translate = helper.getOptions().service();
  * } 
* * @see diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/DetectionTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/DetectionTest.java index 9300fae3e85d..5e2b5c4182c7 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/DetectionTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/DetectionTest.java @@ -32,6 +32,13 @@ public class DetectionTest { @Test public void testFromPb() { + assertEquals(LANGUAGE, DETECTION.getLanguage()); + assertEquals(CONFIDENCE, DETECTION.getConfidence(), 0); + compareDetection(DETECTION, Detection.fromPb(DETECTION_PB)); + } + + @Test + public void testFromPbDeprecated() { assertEquals(LANGUAGE, DETECTION.language()); assertEquals(CONFIDENCE, DETECTION.confidence(), 0); compareDetection(DETECTION, Detection.fromPb(DETECTION_PB)); @@ -39,8 +46,8 @@ public void testFromPb() { private void compareDetection(Detection expected, Detection value) { assertEquals(expected, value); - assertEquals(expected.language(), value.language()); - assertEquals(expected.confidence(), value.confidence(), 0); + assertEquals(expected.getLanguage(), value.getLanguage()); + assertEquals(expected.getConfidence(), value.getConfidence(), 0); assertEquals(expected.hashCode(), value.hashCode()); assertEquals(expected.toString(), value.toString()); } diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/LanguageTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/LanguageTest.java index 4f6849270de0..3eefb2853b37 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/LanguageTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/LanguageTest.java @@ -33,6 +33,16 @@ public class LanguageTest { @Test public void testFromPb() { + assertEquals(CODE, LANGUAGE.getCode()); + assertEquals(NAME, LANGUAGE.getName()); + Language language = Language.fromPb(new LanguagesResource().setLanguage(CODE)); + assertEquals(CODE, language.getCode()); + assertNull(language.getName()); + compareLanguage(LANGUAGE, Language.fromPb(LANGUAGE_PB)); + } + + @Test + public void testFromPbDeprecated() { assertEquals(CODE, LANGUAGE.code()); assertEquals(NAME, LANGUAGE.name()); Language language = Language.fromPb(new LanguagesResource().setLanguage(CODE)); @@ -43,8 +53,8 @@ public void testFromPb() { private void compareLanguage(Language expected, Language value) { assertEquals(expected, value); - assertEquals(expected.name(), value.name()); - assertEquals(expected.code(), value.code()); + assertEquals(expected.getName(), value.getName()); + assertEquals(expected.getCode(), value.getCode()); assertEquals(expected.hashCode(), value.hashCode()); assertEquals(expected.toString(), value.toString()); } diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/OptionTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/OptionTest.java index 152e5c10c455..1151ce9b73cd 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/OptionTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/OptionTest.java @@ -51,11 +51,11 @@ public void testHashCode() { @Test public void testConstructor() { - assertEquals(RPC_OPTION, OPTION.rpcOption()); - assertEquals(VALUE, OPTION.value()); + assertEquals(RPC_OPTION, OPTION.getRpcOption()); + assertEquals(VALUE, OPTION.getValue()); Option option = new Option(RPC_OPTION, null) {}; - assertEquals(RPC_OPTION, option.rpcOption()); - assertNull(option.value()); + assertEquals(RPC_OPTION, option.getRpcOption()); + assertNull(option.getValue()); thrown.expect(NullPointerException.class); new Option(null, VALUE) {}; } diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateImplTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateImplTest.java index 5c98c2c0cd23..f3eb4b04bf92 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateImplTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateImplTest.java @@ -79,7 +79,7 @@ public class TranslateImplTest { private static final LanguageListOption LANGUAGE_LIST_OPTION = LanguageListOption.targetLanguage(TARGET_LANGUAGE); private static final Map LANGUAGE_LIST_OPTIONS = ImmutableMap.of( - TranslateRpc.Option.TARGET_LANGUAGE, LANGUAGE_LIST_OPTION.value()); + TranslateRpc.Option.TARGET_LANGUAGE, LANGUAGE_LIST_OPTION.getValue()); // Translate options private static final TranslateOption TARGET_LANGUAGE_OPTION = @@ -87,8 +87,8 @@ public class TranslateImplTest { private static final TranslateOption SOURCE_LANGUAGE_OPTION = TranslateOption.sourceLanguage("de"); private static final Map TRANSLATE_OPTIONS = ImmutableMap.of( - TranslateRpc.Option.TARGET_LANGUAGE, TARGET_LANGUAGE_OPTION.value(), - TranslateRpc.Option.SOURCE_LANGUAGE, SOURCE_LANGUAGE_OPTION.value()); + TranslateRpc.Option.TARGET_LANGUAGE, TARGET_LANGUAGE_OPTION.getValue(), + TranslateRpc.Option.SOURCE_LANGUAGE, SOURCE_LANGUAGE_OPTION.getValue()); private TranslateOptions options; private TranslateRpcFactory rpcFactoryMock; diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateTest.java index 899ee32a7109..0c87e1e32e31 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateTest.java @@ -32,19 +32,19 @@ public class TranslateTest { public void testListOptions() { // target language LanguageListOption listOption = LanguageListOption.targetLanguage(LANGUAGE); - assertEquals(TranslateRpc.Option.TARGET_LANGUAGE, listOption.rpcOption()); - assertEquals(LANGUAGE, listOption.value()); + assertEquals(TranslateRpc.Option.TARGET_LANGUAGE, listOption.getRpcOption()); + assertEquals(LANGUAGE, listOption.getValue()); } @Test public void testTranslateOptions() { // target language TranslateOption translateOption = TranslateOption.targetLanguage(LANGUAGE); - assertEquals(TranslateRpc.Option.TARGET_LANGUAGE, translateOption.rpcOption()); - assertEquals(LANGUAGE, translateOption.value()); + assertEquals(TranslateRpc.Option.TARGET_LANGUAGE, translateOption.getRpcOption()); + assertEquals(LANGUAGE, translateOption.getValue()); // source language translateOption = TranslateOption.sourceLanguage(LANGUAGE); - assertEquals(TranslateRpc.Option.SOURCE_LANGUAGE, translateOption.rpcOption()); - assertEquals(LANGUAGE, translateOption.value()); + assertEquals(TranslateRpc.Option.SOURCE_LANGUAGE, translateOption.getRpcOption()); + assertEquals(LANGUAGE, translateOption.getValue()); } } diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java index efb819f81362..1e70aaa40044 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslationTest.java @@ -33,6 +33,13 @@ public class TranslationTest { @Test public void testFromPb() { + assertEquals(TRANSLATED_TEXT, TRANSLATION.getTranslatedText()); + assertEquals(SOURCE_LANGUAGE, TRANSLATION.getSourceLanguage()); + compareTranslation(TRANSLATION, Translation.fromPb(TRANSLATION_PB)); + } + + @Test + public void testFromPbDeprecated() { assertEquals(TRANSLATED_TEXT, TRANSLATION.translatedText()); assertEquals(SOURCE_LANGUAGE, TRANSLATION.sourceLanguage()); compareTranslation(TRANSLATION, Translation.fromPb(TRANSLATION_PB)); @@ -40,8 +47,8 @@ public void testFromPb() { private void compareTranslation(Translation expected, Translation value) { assertEquals(expected, value); - assertEquals(expected.translatedText(), value.translatedText()); - assertEquals(expected.sourceLanguage(), value.sourceLanguage()); + assertEquals(expected.getTranslatedText(), value.getTranslatedText()); + assertEquals(expected.getSourceLanguage(), value.getSourceLanguage()); assertEquals(expected.hashCode(), value.hashCode()); assertEquals(expected.toString(), value.toString()); } diff --git a/google-cloud-translate/src/test/java/com/google/cloud/translate/it/ITTranslateTest.java b/google-cloud-translate/src/test/java/com/google/cloud/translate/it/ITTranslateTest.java index c92c09b5ac14..78e7fd11793e 100644 --- a/google-cloud-translate/src/test/java/com/google/cloud/translate/it/ITTranslateTest.java +++ b/google-cloud-translate/src/test/java/com/google/cloud/translate/it/ITTranslateTest.java @@ -37,7 +37,7 @@ public class ITTranslateTest { - private static final Translate TRANSLATE = RemoteTranslateHelper.create().options().service(); + private static final Translate TRANSLATE = RemoteTranslateHelper.create().getOptions().service(); private static final String[] LANGUAGES = {"af", "sq", "ar", "hy", "az", "eu", "be", "bn", "bs", "bg", "ca", "ceb", "ny", "zh-TW", "hr", "cs", "da", "nl", "en", "eo", "et", "tl", "fi", "fr", "gl", "ka", "de", "el", "gu", "ht", "ha", "iw", "hi", "hmn", "hu", "is", "ig", "id", "ga", @@ -51,8 +51,8 @@ public void testListSupportedLanguages() { Set supportedLanguages = new HashSet<>(); List languages = TRANSLATE.listSupportedLanguages(); for (Language language : languages) { - supportedLanguages.add(language.code()); - assertNotNull(language.name()); + supportedLanguages.add(language.getCode()); + assertNotNull(language.getName()); } for (String code : LANGUAGES) { assertTrue(supportedLanguages.contains(code)); @@ -65,8 +65,8 @@ public void testListSupportedLanguagesWithOptions() { List languages = TRANSLATE.listSupportedLanguages( LanguageListOption.targetLanguage("es")); for (Language language : languages) { - supportedLanguages.add(language.code()); - assertNotNull(language.name()); + supportedLanguages.add(language.getCode()); + assertNotNull(language.getName()); } for (String code : LANGUAGES) { assertTrue(supportedLanguages.contains(code)); @@ -77,49 +77,49 @@ public void testListSupportedLanguagesWithOptions() { public void testDetectLanguageOfTexts() { List detections = TRANSLATE.detect("Hello", "Hallo"); Detection detection = detections.get(0); - assertEquals("en", detection.language()); + assertEquals("en", detection.getLanguage()); detection = detections.get(1); - assertEquals("de", detection.language()); + assertEquals("de", detection.getLanguage()); } @Test public void testDetectLanguageOfTextList() { List detections = TRANSLATE.detect(ImmutableList.of("Hello", "Hallo")); Detection detection = detections.get(0); - assertEquals("en", detection.language()); + assertEquals("en", detection.getLanguage()); detection = detections.get(1); - assertEquals("de", detection.language()); + assertEquals("de", detection.getLanguage()); } @Test public void testDetectLanguageOfText() { Detection detection = TRANSLATE.detect("Hello"); - assertEquals("en", detection.language()); + assertEquals("en", detection.getLanguage()); } @Test public void testTranslateTextList() { List translations = TRANSLATE.translate(ImmutableList.of("Hola", "Hallo")); Translation translation = translations.get(0); - assertEquals("Hello", translation.translatedText()); - assertEquals("es", translation.sourceLanguage()); + assertEquals("Hello", translation.getTranslatedText()); + assertEquals("es", translation.getSourceLanguage()); translation = translations.get(1); - assertEquals("Hello", translation.translatedText()); - assertEquals("de", translation.sourceLanguage()); + assertEquals("Hello", translation.getTranslatedText()); + assertEquals("de", translation.getSourceLanguage()); } @Test public void testTranslateText() { Translation translation = TRANSLATE.translate("Hola"); - assertEquals("Hello", translation.translatedText()); - assertEquals("es", translation.sourceLanguage()); + assertEquals("Hello", translation.getTranslatedText()); + assertEquals("es", translation.getSourceLanguage()); } @Test public void testTranslateTextWithOptions() { Translation translation = TRANSLATE.translate("Hola", TranslateOption.sourceLanguage("es"), TranslateOption.targetLanguage("de")); - assertEquals("Hallo", translation.translatedText()); - assertEquals("es", translation.sourceLanguage()); + assertEquals("Hallo", translation.getTranslatedText()); + assertEquals("es", translation.getSourceLanguage()); } }