From 724414f65ddc4d588694895ef26b1ace5e4a26de Mon Sep 17 00:00:00 2001 From: gwatson Date: Tue, 27 Mar 2018 16:12:06 -0400 Subject: [PATCH 1/2] Expose the publishAllOutstanding() method as public So that external systems that need to ensure that all messages have been published can clear a batch. --- .../src/main/java/com/google/cloud/pubsub/v1/Publisher.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java index 56895d66b400..748576d3ee15 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java @@ -290,7 +290,8 @@ public void run() { } } - private void publishAllOutstanding() { + /** publish any outstanding batches if non-empty */ + public void publishAllOutstanding() { messagesBatchLock.lock(); OutstandingBatch batchToSend; try { From 8f2f5b39fa0e87c182d96cec83dbf7c8a8eb964b Mon Sep 17 00:00:00 2001 From: Gray Watson Date: Tue, 3 Apr 2018 00:08:10 -0400 Subject: [PATCH 2/2] expanded comment from feedback --- .../src/main/java/com/google/cloud/pubsub/v1/Publisher.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java index 748576d3ee15..55434aa17775 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java @@ -290,7 +290,11 @@ public void run() { } } - /** publish any outstanding batches if non-empty */ + /** + * Publish any outstanding batches if non-empty. This method sends buffered messages, but does + * not wait for the send operations to complete. To wait for messages to send, call {@code get} + * on the futures returned from {@code publish}. + */ public void publishAllOutstanding() { messagesBatchLock.lock(); OutstandingBatch batchToSend;