diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java index f932887f1080..2cf9a997e8d2 100644 --- a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java +++ b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java @@ -147,13 +147,9 @@ public void onNext(BatchGetDocumentsResponse response) { numResponses++; if (numResponses == 1) { - tracer - .getCurrentSpan() - .addAnnotation("Firestore.BatchGet: First response"); + tracer.getCurrentSpan().addAnnotation("Firestore.BatchGet: First response"); } else if (numResponses % 100 == 0) { - tracer - .getCurrentSpan() - .addAnnotation("Firestore.BatchGet: Received 100 responses"); + tracer.getCurrentSpan().addAnnotation("Firestore.BatchGet: Received 100 responses"); } switch (response.getResultCase()) { diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java index fcff4838dd79..75040e181f40 100644 --- a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java +++ b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java @@ -924,7 +924,8 @@ private void stream( request.setTransaction(transactionId); } - Tracing.getTracer().getCurrentSpan() + Tracing.getTracer() + .getCurrentSpan() .addAnnotation( "Firestore.Query: Start", ImmutableMap.of( @@ -940,13 +941,13 @@ private void stream( public void onNext(RunQueryResponse response) { if (!firstResponse) { firstResponse = true; - Tracing.getTracer().getCurrentSpan() - .addAnnotation("Firestore.Query: First response"); + Tracing.getTracer().getCurrentSpan().addAnnotation("Firestore.Query: First response"); } if (response.hasDocument()) { numDocuments++; if (numDocuments % 100 == 0) { - Tracing.getTracer().getCurrentSpan() + Tracing.getTracer() + .getCurrentSpan() .addAnnotation("Firestore.Query: Received 100 documents"); } Document document = response.getDocument(); @@ -970,12 +971,12 @@ public void onError(Throwable throwable) { @Override public void onCompleted() { - Tracing.getTracer().getCurrentSpan() + Tracing.getTracer() + .getCurrentSpan() .addAnnotation( "Firestore.Query: Completed", ImmutableMap.of( - "numDocuments", - AttributeValue.longAttributeValue(numDocuments))); + "numDocuments", AttributeValue.longAttributeValue(numDocuments))); documentObserver.onCompleted(readTime); } }; diff --git a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java index 785de6108963..7b48c1425495 100644 --- a/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java +++ b/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java @@ -578,9 +578,11 @@ private T performDelete( /** Commit the current batch. */ ApiFuture> commit(@Nullable ByteString transactionId) { - Tracing.getTracer().getCurrentSpan().addAnnotation( - "CloudFirestore.Commit", - ImmutableMap.of("numDocuments", AttributeValue.longAttributeValue(mutations.size()))); + Tracing.getTracer() + .getCurrentSpan() + .addAnnotation( + "CloudFirestore.Commit", + ImmutableMap.of("numDocuments", AttributeValue.longAttributeValue(mutations.size()))); final CommitRequest.Builder request = CommitRequest.newBuilder(); request.setDatabase(firestore.getDatabaseName()); diff --git a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java index 8c756877eab3..a958631b843f 100644 --- a/google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java +++ b/google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java @@ -536,16 +536,16 @@ public void getResult() throws Exception { Iterator changeIterator = result.getDocumentChanges().iterator(); DocumentChange documentChange = changeIterator.next(); - assertEquals("doc1",documentChange.getDocument().getId()); - assertEquals(DocumentChange.Type.ADDED,documentChange.getType()); - assertEquals(-1,documentChange.getOldIndex()); - assertEquals(0,documentChange.getNewIndex()); + assertEquals("doc1", documentChange.getDocument().getId()); + assertEquals(DocumentChange.Type.ADDED, documentChange.getType()); + assertEquals(-1, documentChange.getOldIndex()); + assertEquals(0, documentChange.getNewIndex()); documentChange = changeIterator.next(); - assertEquals("doc2",documentChange.getDocument().getId()); - assertEquals(DocumentChange.Type.ADDED,documentChange.getType()); - assertEquals(-1,documentChange.getOldIndex()); - assertEquals(1,documentChange.getNewIndex()); + assertEquals("doc2", documentChange.getDocument().getId()); + assertEquals(DocumentChange.Type.ADDED, documentChange.getType()); + assertEquals(-1, documentChange.getOldIndex()); + assertEquals(1, documentChange.getNewIndex()); assertFalse(changeIterator.hasNext());