From 5e86e5a25afec1bfd2e94e516ad348667dbb666c Mon Sep 17 00:00:00 2001 From: Charles Li Date: Fri, 7 Dec 2018 17:06:08 -0500 Subject: [PATCH 1/2] modified package-private to public --- .../src/main/java/com/google/cloud/firestore/BasePath.java | 2 +- .../src/main/java/com/google/cloud/firestore/UpdateBuilder.java | 2 +- .../src/main/java/com/google/cloud/storage/Option.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java index de76bd1d87e4..964f95003e33 100644 --- a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java +++ b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/BasePath.java @@ -25,7 +25,7 @@ * BasePath represents a path sequence in the Firestore database. It is composed of an ordered * sequence of string segments. */ -abstract class BasePath> implements Comparable { +public abstract class BasePath> implements Comparable { /** * Returns the segments that make up this path. diff --git a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java index 6b69c40bb4bf..b8d586c90c89 100644 --- a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java +++ b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java @@ -43,7 +43,7 @@ * Abstract class that collects and bundles all write operations for {@link Transaction} and {@link * WriteBatch}. */ -abstract class UpdateBuilder { +public abstract class UpdateBuilder { private static class Mutation { Write.Builder document; diff --git a/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java b/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java index db61498f003f..bf9e01037b05 100644 --- a/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java +++ b/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java @@ -27,7 +27,7 @@ /** * Base class for Storage operation option. */ -abstract class Option implements Serializable { +public abstract class Option implements Serializable { private static final long serialVersionUID = -73199088766477208L; From ae3b35e539d2fe7cf5ccda15b148173c8bf8a778 Mon Sep 17 00:00:00 2001 From: Charles Li Date: Fri, 28 Dec 2018 15:49:36 -0500 Subject: [PATCH 2/2] update format for storage/Option.java --- .../src/main/java/com/google/cloud/storage/Option.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java b/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java index bf9e01037b05..3d2185219637 100644 --- a/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java +++ b/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/Option.java @@ -24,9 +24,7 @@ import java.io.Serializable; import java.util.Objects; -/** - * Base class for Storage operation option. - */ +/** Base class for Storage operation option. */ public abstract class Option implements Serializable { private static final long serialVersionUID = -73199088766477208L;