From 3b33916b35d32b58a0b6688783933375e4709819 Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Wed, 16 Jan 2019 10:36:24 -0800 Subject: [PATCH 1/2] Pub/Sub: default values in batch settings comments Ref: https://github.com/googleapis/gax-java/blob/master/gax/src/main/java/com/google/api/gax/batching/BatchingSettings.java --- .../cloud/examples/pubsub/snippets/PublisherSnippets.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java index dbb8045861d4..3bd30a797b8b 100644 --- a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java +++ b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java @@ -90,8 +90,8 @@ public Publisher getPublisherWithCustomBatchSettings(ProjectTopicName topicName) throws Exception { // [START pubsub_publisher_batch_settings] // Batch settings control how the publisher batches messages - long requestBytesThreshold = 5000L; // default : 1kb - long messageCountBatchSize = 10L; // default : 100 + long requestBytesThreshold = 5000L; // default : 1b + long messageCountBatchSize = 10L; // default : 1 Duration publishDelayThreshold = Duration.ofMillis(100); // default : 1 ms From 424599b95e9e926267e59974845f7d6066dd2aac Mon Sep 17 00:00:00 2001 From: Tianzi Cai Date: Wed, 16 Jan 2019 10:52:01 -0800 Subject: [PATCH 2/2] Verbose comment --- .../cloud/examples/pubsub/snippets/PublisherSnippets.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java index 3bd30a797b8b..32f438d0daba 100644 --- a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java +++ b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java @@ -90,8 +90,8 @@ public Publisher getPublisherWithCustomBatchSettings(ProjectTopicName topicName) throws Exception { // [START pubsub_publisher_batch_settings] // Batch settings control how the publisher batches messages - long requestBytesThreshold = 5000L; // default : 1b - long messageCountBatchSize = 10L; // default : 1 + long requestBytesThreshold = 5000L; // default : 1 byte + long messageCountBatchSize = 10L; // default : 1 message Duration publishDelayThreshold = Duration.ofMillis(100); // default : 1 ms