From 8ac77e6617edbd46d56c86e013d6e0735b28a991 Mon Sep 17 00:00:00 2001 From: Ray Tsang Date: Tue, 2 Apr 2019 14:37:17 -0400 Subject: [PATCH] auto close input stream --- .../src/main/java/com/google/cloud/MetadataConfig.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/MetadataConfig.java b/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/MetadataConfig.java index 867b0253acef..8f1bac04ca69 100644 --- a/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/MetadataConfig.java +++ b/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/MetadataConfig.java @@ -73,10 +73,11 @@ public static String getAttribute(String attributeName) { connection.setConnectTimeout(TIMEOUT_MS); connection.setReadTimeout(TIMEOUT_MS); connection.setRequestProperty("Metadata-Flavor", "Google"); - InputStream input = connection.getInputStream(); - if (connection.getResponseCode() == 200) { - try (BufferedReader reader = new BufferedReader(new InputStreamReader(input, UTF_8))) { - return reader.readLine(); + try (InputStream input = connection.getInputStream()) { + if (connection.getResponseCode() == 200) { + try (BufferedReader reader = new BufferedReader(new InputStreamReader(input, UTF_8))) { + return reader.readLine(); + } } } } catch (IOException ignore) {