From 2c2c80141567a7933a43ce4ee11e5a92cb0f19a3 Mon Sep 17 00:00:00 2001
From: Igor Bernstein <igorbernstein@google.com>
Date: Mon, 29 Apr 2019 15:16:45 -0400
Subject: [PATCH] Bigtable: filter out all `@InternalApi` classed from the
 javadocs

Ideally this should be done via a custom doclet that would filter out any classes annotated with `@InternalOnly`, but this doesn't currently exist. Please note that the exclusion are duplicated across google-cloud-clients/pom.xml and google-cloud-bigtable/pom.xml to support the Jeff's work on splitting javadocs into multiple sites (https://github.com/googleapis/google-cloud-java/pull/5019)
---
 .../google-cloud-bigtable/pom.xml             | 35 ++++++++++++++++++
 google-cloud-clients/pom.xml                  | 36 +++++++++++++++++++
 2 files changed, 71 insertions(+)

diff --git a/google-cloud-clients/google-cloud-bigtable/pom.xml b/google-cloud-clients/google-cloud-bigtable/pom.xml
index 6e709e4f19ef..8ef325b95ac3 100644
--- a/google-cloud-clients/google-cloud-bigtable/pom.xml
+++ b/google-cloud-clients/google-cloud-bigtable/pom.xml
@@ -150,6 +150,41 @@
           <nohelp>true</nohelp>
           <doclint>none</doclint>
           <splitindex>true</splitindex>
+
+          <sourceFileExcludes>
+            <!-- TODO(igorbernstein): use a custom doclet to exclude @InternalApi classes from javadoc -->
+            <!-- Hide @InternalApi classes -->
+            <exclude>com/google/cloud/bigtable/gaxx/**</exclude>
+
+            <!-- Hide @InternalApi classes for InstanceAdmin -->
+            <exclude>com/google/cloud/bigtable/admin/v2/internal/**</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java</exclude>
+
+            <!-- Hide @InternalApi classes for TableAdmin -->
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java</exclude>
+
+            <!-- Hide @InternalApi classes for Data -->
+            <exclude>com/google/cloud/bigtable/data/v2/internal/**</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/BaseBigtableDataClient.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/BaseBigtableDataSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/BigtableStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/GrpcBigtableStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/GrpcBigtableCallableFactory.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/mutaterows/**</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/readrows/**</exclude>
+          </sourceFileExcludes>
+
           <offlineLinks>
             <offlineLink>
               <url>${project.javadoc.protobufBaseURL}</url>
diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml
index 68c2248b3216..c588b6892ede 100644
--- a/google-cloud-clients/pom.xml
+++ b/google-cloud-clients/pom.xml
@@ -796,6 +796,42 @@
               <packages>com.google.cloud.compute.deprecated*</packages>
             </group>
           </groups>
+
+          <!-- TODO(chingor13): Remove this once we switch to per client javadoc sites -->
+          <sourceFileExcludes>
+            <!-- TODO(igorbernstein): use a custom doclet to exclude @InternalApi classes from javadoc -->
+            <!-- Bigtable: Hide @InternalApi classes -->
+            <exclude>com/google/cloud/bigtable/gaxx/**</exclude>
+
+            <!-- Bigtable: Hide @InternalApi classes for InstanceAdmin -->
+            <exclude>com/google/cloud/bigtable/admin/v2/internal/**</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminClient.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableInstanceAdminSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminCallableFactory.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableInstanceAdminStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/BigtableInstanceAdminStub.java</exclude>
+
+            <!-- Bigtable: Hide @InternalApi classes for TableAdmin -->
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminClient.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/BaseBigtableTableAdminSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminCallableFactory.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/GrpcBigtableTableAdminStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/BigtableTableAdminStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/admin/v2/stub/EnhancedBigtableTableAdminStub.java</exclude>
+
+            <!-- Bigtable: Hide @InternalApi classes for Data -->
+            <exclude>com/google/cloud/bigtable/data/v2/internal/**</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/BaseBigtableDataClient.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/BaseBigtableDataSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/BigtableStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/BigtableStubSettings.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/GrpcBigtableStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/GrpcBigtableCallableFactory.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/mutaterows/**</exclude>
+            <exclude>com/google/cloud/bigtable/data/v2/stub/readrows/**</exclude>
+          </sourceFileExcludes>
+
           <links>
             <link>https://grpc.io/grpc-java/javadoc/</link>
             <link>https://developers.google.com/protocol-buffers/docs/reference/java/</link>