From a21a669967ee497aed532d17c28aded09e51ece8 Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 30 Jul 2019 16:20:35 -0700 Subject: [PATCH 1/3] Firestore: Add note about potential flakiness in the new Watch test --- .../test/java/com/google/cloud/firestore/it/ITSystemTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java index 199219098475..2442a17ab9e6 100644 --- a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java +++ b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java @@ -920,6 +920,10 @@ public void queryWatch() throws Exception { // case there is a hang during the test the whole suite isn't taken with it) // D. After all updates have been performed and the expected number of events have been // received, assertions on the events will be performed. + // + // Note: There is a potential that this test fails if the Firestore backend does not send us + // individual changes for every document update, but rather merges two or more changes into a + // single event. We have, however, not seen any failures during thousands of test runs. ListenerRegistration registration = null; final ExecutorService updatesExecutor = Executors.newCachedThreadPool(); From 861316517ae9e428585b279bd8f4c46b441bf82c Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 30 Jul 2019 16:21:47 -0700 Subject: [PATCH 2/3] Update ITSystemTest.java --- .../test/java/com/google/cloud/firestore/it/ITSystemTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java index 2442a17ab9e6..9a395aa962ad 100644 --- a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java +++ b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java @@ -921,9 +921,9 @@ public void queryWatch() throws Exception { // D. After all updates have been performed and the expected number of events have been // received, assertions on the events will be performed. // - // Note: There is a potential that this test fails if the Firestore backend does not send us + // Note: There is a potential that this test fails if the Firestore backend chooses not send us // individual changes for every document update, but rather merges two or more changes into a - // single event. We have, however, not seen any failures during thousands of test runs. + // single event. We have, however, not seen any failures during thousands of test runs. ListenerRegistration registration = null; final ExecutorService updatesExecutor = Executors.newCachedThreadPool(); From 9d544bc306b7e996b57e28baded7bf98cfe4456b Mon Sep 17 00:00:00 2001 From: Sebastian Schmidt Date: Tue, 30 Jul 2019 21:01:54 -0700 Subject: [PATCH 3/3] Update ITSystemTest.java --- .../java/com/google/cloud/firestore/it/ITSystemTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java index 9a395aa962ad..de19f5492da7 100644 --- a/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java +++ b/google-cloud-clients/google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java @@ -921,9 +921,9 @@ public void queryWatch() throws Exception { // D. After all updates have been performed and the expected number of events have been // received, assertions on the events will be performed. // - // Note: There is a potential that this test fails if the Firestore backend chooses not send us - // individual changes for every document update, but rather merges two or more changes into a - // single event. We have, however, not seen any failures during thousands of test runs. + // Note: There is a potential that this test fails if the Firestore backend chooses not to send + // us individual changes for every document update, but rather merges two or more changes into + // a single event. We have, however, not seen any failures during thousands of test runs. ListenerRegistration registration = null; final ExecutorService updatesExecutor = Executors.newCachedThreadPool();