From 5b9b22ac51a4396fd2716a4f42ceb7e1e43786f9 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:11:37 -0700 Subject: [PATCH 01/14] update gax to 1.48.0 --- google-cloud-bom/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-bom/pom.xml b/google-cloud-bom/pom.xml index afdccc158cf2..84a4ed711b22 100644 --- a/google-cloud-bom/pom.xml +++ b/google-cloud-bom/pom.xml @@ -168,7 +168,7 @@ com.google.api gax-bom - 1.47.1 + 1.48.0 pom import From 24bcc705384ee1157765c9fe165adcbd4a2437ea Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:12:13 -0700 Subject: [PATCH 02/14] update google-auth-library to 0.17.0 --- google-cloud-clients/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index 147c38081733..12fb1626f4e0 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -158,8 +158,8 @@ 1.47.1 1.8.1 - 0.16.2 1.23.0 + 0.17.0 28.0-android 1.31.0 From cd2c5eca038698ef055ab7f0f9b84c57b32bc541 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:16:06 -0700 Subject: [PATCH 03/14] update grpc to 1.23.0 and import grpc-bom --- google-api-grpc/pom.xml | 20 ++++++--------- google-cloud-clients/pom.xml | 49 +++++++----------------------------- 2 files changed, 17 insertions(+), 52 deletions(-) diff --git a/google-api-grpc/pom.xml b/google-api-grpc/pom.xml index ad800bfc61c3..5bfe0fb11a2b 100644 --- a/google-api-grpc/pom.xml +++ b/google-api-grpc/pom.xml @@ -14,6 +14,7 @@ UTF-8 UTF-8 https://googleapis.dev/java/google-api-grpc/latest + 1.23.0 @@ -101,22 +102,17 @@ - - com.google.protobuf - protobuf-java - 3.7.1 - io.grpc - grpc-stub - 1.23.0 - compile + grpc-bom + ${grpc.version} + pom + import - io.grpc - grpc-protobuf - 1.23.0 - compile + com.google.protobuf + protobuf-java + 3.7.1 com.google.api diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index 12fb1626f4e0..b48e66ac32fb 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -211,6 +211,14 @@ pom import + + io.grpc + grpc-bom + ${grpc.version} + pom + import + + com.google.apis google-api-services-bigquery @@ -285,46 +293,7 @@ json 20180813 - - io.grpc - grpc-core - ${grpc.version} - - - io.grpc - grpc-netty - ${grpc.version} - - - io.grpc - grpc-netty-shaded - ${grpc.version} - - - io.grpc - grpc-stub - ${grpc.version} - - - io.grpc - grpc-auth - ${grpc.version} - - - io.grpc - grpc-protobuf - ${grpc.version} - - - io.grpc - grpc-context - ${grpc.version} - - - io.grpc - grpc-testing - ${grpc.version} - + com.google.code.findbugs jsr305 From de39e9f1f5ed2da89133cdf6369d669bf0fcf0f6 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:17:01 -0700 Subject: [PATCH 04/14] cleanup guava versions to 28.0-android --- google-cloud-testing/pom.xml | 2 +- google-cloud-util/google-cloud-compat-checker/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/google-cloud-testing/pom.xml b/google-cloud-testing/pom.xml index 18067daee4e9..f87a4c449c8b 100644 --- a/google-cloud-testing/pom.xml +++ b/google-cloud-testing/pom.xml @@ -59,7 +59,7 @@ com.google.guava guava-testlib - 26.0-android + 28.0-android junit diff --git a/google-cloud-util/google-cloud-compat-checker/pom.xml b/google-cloud-util/google-cloud-compat-checker/pom.xml index b3b9dda2904f..e0d6fdfb6291 100644 --- a/google-cloud-util/google-cloud-compat-checker/pom.xml +++ b/google-cloud-util/google-cloud-compat-checker/pom.xml @@ -18,7 +18,7 @@ google-cloud-compat-checker 1.23.0 - 27.1-android + 28.0-android From 495a0c7373a174af58ef0123bb05f702cd6a4f66 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:22:15 -0700 Subject: [PATCH 05/14] update protobuf to 3.9.1 and use bom --- google-api-grpc/pom.xml | 6 ++++-- google-cloud-clients/pom.xml | 17 +++++++---------- .../google-cloud-conformance-tests/pom.xml | 2 +- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/google-api-grpc/pom.xml b/google-api-grpc/pom.xml index 5bfe0fb11a2b..6a0fd7ceed81 100644 --- a/google-api-grpc/pom.xml +++ b/google-api-grpc/pom.xml @@ -111,8 +111,10 @@ com.google.protobuf - protobuf-java - 3.7.1 + protobuf-bom + 3.9.1 + pom + import com.google.api diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index b48e66ac32fb..386a20947c60 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -218,6 +218,13 @@ pom import + + com.google.protobuf + protobuf-bom + ${protobuf.version} + pom + import + com.google.apis @@ -299,16 +306,6 @@ jsr305 3.0.2 - - com.google.protobuf - protobuf-java - ${protobuf.version} - - - com.google.protobuf - protobuf-java-util - ${protobuf.version} - com.google.guava guava diff --git a/google-cloud-testing/google-cloud-conformance-tests/pom.xml b/google-cloud-testing/google-cloud-conformance-tests/pom.xml index 2e949c9bdd22..e78ec10905df 100644 --- a/google-cloud-testing/google-cloud-conformance-tests/pom.xml +++ b/google-cloud-testing/google-cloud-conformance-tests/pom.xml @@ -14,7 +14,7 @@ - 3.7.1 + 3.9.1 From de09374b5a3d278bae55e83f68733d3787ad2a1d Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:31:47 -0700 Subject: [PATCH 06/14] update opencensus to 0.23.0 --- google-cloud-clients/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index 386a20947c60..7183ea0dc40a 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -166,7 +166,7 @@ 1.30.1 3.9.1 - 0.21.0 + 0.23.0 4.5.5 From 40a3ce1d2d21cfbecf3ac9691ed957ba75d46685 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:45:32 -0700 Subject: [PATCH 07/14] update autovalue to 1.6.5 --- google-cloud-clients/pom.xml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index 7183ea0dc40a..db014d6bd355 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -172,6 +172,7 @@ 3.6 2.6 + 1.6.5 @@ -314,7 +315,12 @@ com.google.auto.value auto-value - 1.4 + ${autovalue.version} + + + com.google.auto.value + auto-value-annotations + ${autovalue.version} io.opencensus From 17bbde26de13b0dd8f698075c8e76b513cca7e53 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 07:52:07 -0700 Subject: [PATCH 08/14] latest autovalue is 1.6.6 --- google-cloud-clients/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index db014d6bd355..cec1ee3d9e33 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -172,7 +172,7 @@ 3.6 2.6 - 1.6.5 + 1.6.6 From ef67ae4398e5eccdde4c3099a725b05bbb492d5d Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 11:49:28 -0700 Subject: [PATCH 09/14] enable runningSpanStore to capture spans for testing --- .../com/google/cloud/pubsub/v1/OpenCensusUtilTest.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java b/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java index d4230003907d..9126b67ba6b1 100644 --- a/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java +++ b/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java @@ -43,6 +43,8 @@ import java.util.Collection; import java.util.List; import java.util.concurrent.TimeUnit; + +import org.junit.BeforeClass; import org.junit.Test; /** Tests for {@link OpenCensusUtil}. */ @@ -53,6 +55,11 @@ public class OpenCensusUtilTest { private static final TagValue TEST_TAG_VAL = TagValue.create("TEST_TAG_VAL"); private static final String TEST_PARENT_LINK_NAME = "TEST_PARENT_LINK"; + @BeforeClass + public static void configureOpenCensus() { + Tracing.getExportComponent().getRunningSpanStore().setMaxNumberOfSpans(5); + } + // Verifies that trace contexts propagated as an attribute are set as the parent link in the // message receiver and that the tag context is not change (for now). @Test @@ -148,7 +155,7 @@ private void assertSpanCount(int expected) { } Thread.yield(); if (watch.elapsed(TimeUnit.SECONDS) >= 5) { - fail(); + fail("failed to get spans in 5 seconds"); } } } From 3d572faae57df1dfbb29d492319d52630cce0892 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 12:20:29 -0700 Subject: [PATCH 10/14] lint --- .../test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java b/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java index 9126b67ba6b1..afa316220681 100644 --- a/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java +++ b/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/OpenCensusUtilTest.java @@ -43,7 +43,6 @@ import java.util.Collection; import java.util.List; import java.util.concurrent.TimeUnit; - import org.junit.BeforeClass; import org.junit.Test; From 3426821a5bf2c04cdb99cc0566cb8664d7b0eda5 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 13:23:09 -0700 Subject: [PATCH 11/14] cannot upgrade autovalue right now --- google-cloud-clients/pom.xml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index cec1ee3d9e33..ecf18493e60e 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -172,7 +172,7 @@ 3.6 2.6 - 1.6.6 + 1.4 @@ -317,11 +317,6 @@ auto-value ${autovalue.version} - - com.google.auto.value - auto-value-annotations - ${autovalue.version} - io.opencensus opencensus-api From 8e24848afa836c0a1d3475a425ecee7b53ba5986 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 13:45:31 -0700 Subject: [PATCH 12/14] try profiles for autovalue compatibility --- google-cloud-clients/pom.xml | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index ecf18493e60e..5e26f958046d 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -172,7 +172,6 @@ 3.6 2.6 - 1.4 @@ -919,6 +918,35 @@ + + autovalue-java7 + + 1.7 + + + 1.4 + + + + + autovalue-java8 + + [1.8,) + + + 1.6.6 + + + + + com.google.auto.value + auto-value-annotations + ${autovalue.version} + + + + + checkstyle-tests From 278c59d9dfb70a9dceffa83835993f18649ab837 Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 14:18:13 -0700 Subject: [PATCH 13/14] exclusion to fix enforcer --- google-cloud-clients/google-cloud-core/pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/google-cloud-clients/google-cloud-core/pom.xml b/google-cloud-clients/google-cloud-core/pom.xml index d4b9af695a68..94efee8f8ab2 100644 --- a/google-cloud-clients/google-cloud-core/pom.xml +++ b/google-cloud-clients/google-cloud-core/pom.xml @@ -53,6 +53,12 @@ com.google.truth truth test + + + com.google.auto.value + auto-value-annotations + + com.google.guava From 93931eb9d616372500d5979d39b2ab2a256c48cd Mon Sep 17 00:00:00 2001 From: Jeff Ching Date: Wed, 21 Aug 2019 15:19:52 -0700 Subject: [PATCH 14/14] undo exclusion, try via profile --- google-cloud-clients/google-cloud-core/pom.xml | 6 ------ google-cloud-clients/pom.xml | 9 +++++++++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/google-cloud-clients/google-cloud-core/pom.xml b/google-cloud-clients/google-cloud-core/pom.xml index 94efee8f8ab2..d4b9af695a68 100644 --- a/google-cloud-clients/google-cloud-core/pom.xml +++ b/google-cloud-clients/google-cloud-core/pom.xml @@ -53,12 +53,6 @@ com.google.truth truth test - - - com.google.auto.value - auto-value-annotations - - com.google.guava diff --git a/google-cloud-clients/pom.xml b/google-cloud-clients/pom.xml index 5e26f958046d..f20d7148e637 100644 --- a/google-cloud-clients/pom.xml +++ b/google-cloud-clients/pom.xml @@ -926,6 +926,15 @@ 1.4 + + + + com.google.auto.value + auto-value-annotations + 1.6.6 + + +