From f8328e31e3a0057e23471c883040977091380b90 Mon Sep 17 00:00:00 2001 From: Simon Corsin Date: Thu, 23 Mar 2017 19:44:59 -0400 Subject: [PATCH 1/2] Fixed insert in bigtable that would set incorrect timestamps. Fixes #2120. --- packages/bigtable/src/mutation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bigtable/src/mutation.js b/packages/bigtable/src/mutation.js index 7e391fca61c..27cb8d3f5db 100644 --- a/packages/bigtable/src/mutation.js +++ b/packages/bigtable/src/mutation.js @@ -169,7 +169,7 @@ Mutation.encodeSetCell = function(data) { var timestamp = cell.timestamp; if (is.date(timestamp)) { - timestamp = timestamp.getTime(); + timestamp = timestamp.getTime() * 1000; } var setCell = { From 1e5405a4d9875061cc51416f62647d2c2475d751 Mon Sep 17 00:00:00 2001 From: Simon Corsin Date: Fri, 24 Mar 2017 09:22:02 -0400 Subject: [PATCH 2/2] Fixed unit tests. --- packages/bigtable/test/mutation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bigtable/test/mutation.js b/packages/bigtable/test/mutation.js index d1e673d7116..57304b97e9d 100644 --- a/packages/bigtable/test/mutation.js +++ b/packages/bigtable/test/mutation.js @@ -185,7 +185,7 @@ describe('Bigtable/Mutation', function() { setCell: { familyName: 'follows', columnQualifier: 'gwashington', - timestampMicros: timestamp, + timestampMicros: timestamp * 1000, // Convert ms to ms value: 1 } }]);