Skip to content

Commit 1bd07ed

Browse files
authored
build: fix presubmit (#257)
* build: fix presubmit * fix build * fix build
1 parent 3011728 commit 1bd07ed

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

packages/googleapis-common-protos/noxfile.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,24 +64,23 @@ def unit(session, repository, package, prerelease, protobuf_implementation, work
6464
# Pin mock due to https://github.com/googleapis/python-pubsub/issues/840
6565
session.install("mock==5.0.0", "pytest", "pytest-cov")
6666

67-
install_command = ["-e", f"{working_dir}/{downstream_dir}"]
6867
if prerelease:
68+
session.install("-e", f"{working_dir}/{downstream_dir}")
6969
install_prerelease_dependencies(
7070
session,
7171
f"{working_dir}/{downstream_dir}/testing/constraints-{UNIT_TEST_PYTHON_VERSIONS[0]}.txt",
7272
)
73-
# Use the `--no-deps` options to allow pre-release versions of dependencies to be installed
74-
install_command.extend(["--no-deps"])
7573
else:
74+
install_command = ["-e", f"{working_dir}/{downstream_dir}"]
7675
contraints_file = f"{CURRENT_DIRECTORY}/testing/constraints-{session.python}-{repository}.txt"
7776
if not Path(contraints_file).exists():
7877
contraints_file = f"{CURRENT_DIRECTORY}/testing/constraints-{session.python}.txt"
7978

8079
install_command.extend(["-c", contraints_file])
8180

82-
# These *must* be the last 3 install commands to get the packages from source.
83-
session.install(*install_command)
81+
session.install(*install_command)
8482

83+
# These *must* be the last install commands to get the packages from source.
8584
# Remove the 'cpp' implementation once support for Protobuf 3.x is dropped.
8685
# The 'cpp' implementation requires Protobuf<4.
8786
if protobuf_implementation == "cpp":

0 commit comments

Comments
 (0)