Skip to content

Commit 5dd39ac

Browse files
authored
Merge pull request #2638 from daspecster/unify-speech-async-operation-results
Clean up async docs and unify for future GAPIC async.
2 parents c97efbd + 320dee4 commit 5dd39ac

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

packages/google-cloud-speech/google/cloud/speech/operation.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,9 @@ def _update(self, response):
123123
raw_results = response.get('response', {}).get('results', None)
124124
results = []
125125
if raw_results:
126-
for result in raw_results[0]['alternatives']:
127-
results.append(Transcript.from_api_repr(result))
126+
for result in raw_results:
127+
for alternative in result['alternatives']:
128+
results.append(Transcript.from_api_repr(alternative))
128129
if metadata:
129130
self._metadata = Metadata.from_api_repr(metadata)
130131

packages/google-cloud-speech/unit_tests/test_operation.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def test_ctor_defaults(self):
3636

3737
def test_from_api_repr(self):
3838
from unit_tests._fixtures import OPERATION_COMPLETE_RESPONSE
39-
from google.cloud.speech.operation import Transcript
39+
from google.cloud.speech.transcript import Transcript
4040
from google.cloud.speech.metadata import Metadata
4141
RESPONSE = OPERATION_COMPLETE_RESPONSE
4242

@@ -46,10 +46,12 @@ def test_from_api_repr(self):
4646
self.assertEqual('123456789', operation.name)
4747
self.assertTrue(operation.complete)
4848

49+
self.assertEqual(len(operation.results), 1)
4950
self.assertIsInstance(operation.results[0], Transcript)
5051
self.assertEqual(operation.results[0].transcript,
5152
'how old is the Brooklyn Bridge')
52-
self.assertEqual(operation.results[0].confidence, 0.98267895)
53+
self.assertEqual(operation.results[0].confidence,
54+
0.98267895)
5355
self.assertTrue(operation.complete)
5456
self.assertIsInstance(operation.metadata, Metadata)
5557
self.assertEqual(operation.metadata.progress_percent, 100)

0 commit comments

Comments
 (0)