From 0f63e4d52e373a54b8407156d9063d6313579a7d Mon Sep 17 00:00:00 2001 From: PhongChuong Date: Thu, 6 Mar 2025 10:16:23 -0500 Subject: [PATCH 1/6] docs: update error handling comment to be more precise in samples --- .../src/main/java/com/example/bigquery/SimpleApp.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java index 49975a9cc..4f42625b3 100644 --- a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java +++ b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java @@ -67,10 +67,10 @@ public static void simpleApp(String projectId) { // Check for errors if (queryJob == null) { throw new RuntimeException("Job no longer exists"); - } else if (queryJob.getStatus().getError() != null) { - // You can also look at queryJob.getStatus().getExecutionErrors() for all - // errors, not just the latest one. - throw new RuntimeException(queryJob.getStatus().getError().toString()); + } else if (queryJob.getStatus().getExecutionErrors() != null && queryJob.getStatus().getExecutionErrors().size() > 0) { + // TODO(developer): Handle errors here. Notice that an error do not necessarily mean + // that the job has completed or was unsuccessful. + // For more details: https://cloud.google.com/bigquery/troubleshooting-errors } // [END bigquery_simple_app_query] From a32e9839f39b7f81b45f6f6ef66670693cf7b260 Mon Sep 17 00:00:00 2001 From: PhongChuong Date: Thu, 6 Mar 2025 10:19:48 -0500 Subject: [PATCH 2/6] style --- .../snippets/src/main/java/com/example/bigquery/SimpleApp.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java index 4f42625b3..71a85b738 100644 --- a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java +++ b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java @@ -67,7 +67,8 @@ public static void simpleApp(String projectId) { // Check for errors if (queryJob == null) { throw new RuntimeException("Job no longer exists"); - } else if (queryJob.getStatus().getExecutionErrors() != null && queryJob.getStatus().getExecutionErrors().size() > 0) { + } else if (queryJob.getStatus().getExecutionErrors() != null + && queryJob.getStatus().getExecutionErrors().size() > 0) { // TODO(developer): Handle errors here. Notice that an error do not necessarily mean // that the job has completed or was unsuccessful. // For more details: https://cloud.google.com/bigquery/troubleshooting-errors From a39d7dcd92dd841eb4e5e29314efdf0ce97292cc Mon Sep 17 00:00:00 2001 From: PhongChuong Date: Thu, 6 Mar 2025 10:33:31 -0500 Subject: [PATCH 3/6] style --- .../snippets/src/main/java/com/example/bigquery/SimpleApp.java | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java index 71a85b738..1b1ce11f1 100644 --- a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java +++ b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java @@ -72,6 +72,7 @@ public static void simpleApp(String projectId) { // TODO(developer): Handle errors here. Notice that an error do not necessarily mean // that the job has completed or was unsuccessful. // For more details: https://cloud.google.com/bigquery/troubleshooting-errors + throw new RuntimeException("An unhandled error has occurred"); } // [END bigquery_simple_app_query] From 6e6b1870c6413f95c9deb7a3c5adeb18febee870 Mon Sep 17 00:00:00 2001 From: PhongChuong Date: Wed, 12 Mar 2025 14:52:24 -0400 Subject: [PATCH 4/6] update comment --- .../src/main/java/com/example/bigquery/SimpleApp.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java index 1b1ce11f1..7b72bb0f9 100644 --- a/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java +++ b/samples/snippets/src/main/java/com/example/bigquery/SimpleApp.java @@ -69,8 +69,8 @@ public static void simpleApp(String projectId) { throw new RuntimeException("Job no longer exists"); } else if (queryJob.getStatus().getExecutionErrors() != null && queryJob.getStatus().getExecutionErrors().size() > 0) { - // TODO(developer): Handle errors here. Notice that an error do not necessarily mean - // that the job has completed or was unsuccessful. + // TODO(developer): Handle errors here. An error here do not necessarily mean that the job + // has completed or was unsuccessful. // For more details: https://cloud.google.com/bigquery/troubleshooting-errors throw new RuntimeException("An unhandled error has occurred"); } From d234bbbdb75b2e71e0614c52bf09fe8dac929d91 Mon Sep 17 00:00:00 2001 From: PhongChuong Date: Wed, 12 Mar 2025 14:57:35 -0400 Subject: [PATCH 5/6] ignoredUnusedDeclaredDependencies --- pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pom.xml b/pom.xml index a9db710d7..6acbe6622 100644 --- a/pom.xml +++ b/pom.xml @@ -168,6 +168,8 @@ maven-dependency-plugin + io.netty:netty-buffer + io.netty:netty-common org.apache.arrow:arrow-memory-netty From cdac0327a5a8346ce9123c00c797de10886fde31 Mon Sep 17 00:00:00 2001 From: PhongChuong Date: Wed, 12 Mar 2025 15:00:13 -0400 Subject: [PATCH 6/6] revert wrong commit/PR push ignoredUnusedDeclaredDependencies --- pom.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/pom.xml b/pom.xml index 6acbe6622..a9db710d7 100644 --- a/pom.xml +++ b/pom.xml @@ -168,8 +168,6 @@ maven-dependency-plugin - io.netty:netty-buffer - io.netty:netty-common org.apache.arrow:arrow-memory-netty