From 38853c77f432825dd3c88d72db26f3195c596129 Mon Sep 17 00:00:00 2001
From: "release-please[bot]"
 <55107282+release-please[bot]@users.noreply.github.com>
Date: Wed, 27 Jul 2022 20:20:44 +0000
Subject: [PATCH] chore(main): release 2.8.4

---
 CHANGELOG.md                   | 12 ++++++++++++
 google-cloud-core-bom/pom.xml  |  8 ++++----
 google-cloud-core-grpc/pom.xml |  4 ++--
 google-cloud-core-http/pom.xml |  4 ++--
 google-cloud-core/pom.xml      |  4 ++--
 pom.xml                        |  2 +-
 versions.txt                   |  2 +-
 7 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 73ddd4cdb2..2e952c9186 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,17 @@
 # Changelog
 
+## [2.8.4](https://github.com/googleapis/java-core/compare/v2.8.3...v2.8.4) (2022-07-27)
+
+
+### Documentation
+
+* update javadocs for ReadChannel#limit to be more clear ([#880](https://github.com/googleapis/java-core/issues/880)) ([c7de4e2](https://github.com/googleapis/java-core/commit/c7de4e2871d6a32cacc7aab69d826f3afd6301ef))
+
+
+### Dependencies
+
+* Update google-cloud-shared-config to v1.5.3 ([#882](https://github.com/googleapis/java-core/issues/882)) ([aabb0b4](https://github.com/googleapis/java-core/commit/aabb0b42076f8a02e7b31d604add567fa909df6c))
+
 ## [2.8.3](https://github.com/googleapis/java-core/compare/v2.8.2...v2.8.3) (2022-07-26)
 
 
diff --git a/google-cloud-core-bom/pom.xml b/google-cloud-core-bom/pom.xml
index 728502df51..0f90445f9f 100644
--- a/google-cloud-core-bom/pom.xml
+++ b/google-cloud-core-bom/pom.xml
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-core-bom</artifactId>
-  <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+  <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   <packaging>pom</packaging>
   <parent>
     <groupId>com.google.cloud</groupId>
@@ -63,17 +63,17 @@
       <dependency>
         <groupId>com.google.cloud</groupId>
         <artifactId>google-cloud-core</artifactId>
-        <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+        <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
       </dependency>
       <dependency>
         <groupId>com.google.cloud</groupId>
         <artifactId>google-cloud-core-grpc</artifactId>
-        <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+        <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
       </dependency>
       <dependency>
         <groupId>com.google.cloud</groupId>
         <artifactId>google-cloud-core-http</artifactId>
-        <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+        <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
       </dependency>
     </dependencies>
   </dependencyManagement>
diff --git a/google-cloud-core-grpc/pom.xml b/google-cloud-core-grpc/pom.xml
index 677404db56..847748a1f4 100644
--- a/google-cloud-core-grpc/pom.xml
+++ b/google-cloud-core-grpc/pom.xml
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-core-grpc</artifactId>
-  <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+  <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   <packaging>jar</packaging>
   <name>Google Cloud Core gRPC</name>
   <url>https://github.com/googleapis/java-core</url>
@@ -13,7 +13,7 @@
   <parent>
     <groupId>com.google.cloud</groupId>
     <artifactId>google-cloud-core-parent</artifactId>
-    <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+    <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   </parent>
   <properties>
     <site.installationModule>google-cloud-core-grpc</site.installationModule>
diff --git a/google-cloud-core-http/pom.xml b/google-cloud-core-http/pom.xml
index 8b1a429704..269138c15a 100644
--- a/google-cloud-core-http/pom.xml
+++ b/google-cloud-core-http/pom.xml
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-core-http</artifactId>
-  <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+  <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   <packaging>jar</packaging>
   <name>Google Cloud Core HTTP</name>
   <url>https://github.com/googleapis/java-core</url>
@@ -13,7 +13,7 @@
   <parent>
     <groupId>com.google.cloud</groupId>
     <artifactId>google-cloud-core-parent</artifactId>
-    <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+    <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   </parent>
   <properties>
     <site.installationModule>google-cloud-core-http</site.installationModule>
diff --git a/google-cloud-core/pom.xml b/google-cloud-core/pom.xml
index b8c2931b31..691765f15b 100644
--- a/google-cloud-core/pom.xml
+++ b/google-cloud-core/pom.xml
@@ -3,7 +3,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-core</artifactId>
-  <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+  <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   <packaging>jar</packaging>
   <name>Google Cloud Core</name>
   <url>https://github.com/googleapis/java-core</url>
@@ -13,7 +13,7 @@
   <parent>
     <groupId>com.google.cloud</groupId>
     <artifactId>google-cloud-core-parent</artifactId>
-    <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+    <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   </parent>
   <properties>
     <site.installationModule>google-cloud-core</site.installationModule>
diff --git a/pom.xml b/pom.xml
index 62450cb5bc..dc1d55b257 100644
--- a/pom.xml
+++ b/pom.xml
@@ -4,7 +4,7 @@
   <groupId>com.google.cloud</groupId>
   <artifactId>google-cloud-core-parent</artifactId>
   <packaging>pom</packaging>
-  <version>2.8.4-SNAPSHOT</version><!-- {x-version-update:google-cloud-core:current} -->
+  <version>2.8.4</version><!-- {x-version-update:google-cloud-core:current} -->
   <name>Google Cloud Core Parent</name>
   <url>https://github.com/googleapis/java-core</url>
   <description>
diff --git a/versions.txt b/versions.txt
index 5e532d4e6b..ee729e1c0e 100644
--- a/versions.txt
+++ b/versions.txt
@@ -1,4 +1,4 @@
 # Format:
 # module:released-version:current-version
 
-google-cloud-core:2.8.3:2.8.4-SNAPSHOT
+google-cloud-core:2.8.4:2.8.4