From eace3432b4e7470c7494cf6f9b4f34e96150af54 Mon Sep 17 00:00:00 2001 From: Jim Fulton Date: Mon, 23 Aug 2021 13:05:24 -0600 Subject: [PATCH 1/2] chore: Simplify create_job slightly --- google/cloud/bigquery/client.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/google/cloud/bigquery/client.py b/google/cloud/bigquery/client.py index 93ba2aa11..5445ce956 100644 --- a/google/cloud/bigquery/client.py +++ b/google/cloud/bigquery/client.py @@ -1935,9 +1935,8 @@ def create_job( source_type=source_type, ) elif "query" in job_config: - copy_config = copy.deepcopy(job_config) query_job_config = google.cloud.bigquery.job.QueryJobConfig.from_api_repr( - copy_config + copy.deepcopy(job_config) ) query = _get_sub_prop(copy_config, ["query", "query"]) return self.query( From 71a075e95c7f20ba437e6acc48b21a373a34cc24 Mon Sep 17 00:00:00 2001 From: Jim Fulton Date: Mon, 23 Aug 2021 13:23:48 -0600 Subject: [PATCH 2/2] No need for deep copy and need to get the query from job_config --- google/cloud/bigquery/client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/google/cloud/bigquery/client.py b/google/cloud/bigquery/client.py index 5445ce956..e2863e6a5 100644 --- a/google/cloud/bigquery/client.py +++ b/google/cloud/bigquery/client.py @@ -1936,9 +1936,9 @@ def create_job( ) elif "query" in job_config: query_job_config = google.cloud.bigquery.job.QueryJobConfig.from_api_repr( - copy.deepcopy(job_config) + job_config ) - query = _get_sub_prop(copy_config, ["query", "query"]) + query = _get_sub_prop(job_config, ["query", "query"]) return self.query( query, job_config=query_job_config, retry=retry, timeout=timeout )