From 90312162afa9b7787bc7cb5eb021616ae09b9399 Mon Sep 17 00:00:00 2001 From: Your Name Date: Tue, 14 Apr 2020 19:01:23 +0530 Subject: [PATCH] fix(storage): remove expiration strict conversion --- google/cloud/storage/_signing.py | 4 ++-- tests/unit/test__signing.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/google/cloud/storage/_signing.py b/google/cloud/storage/_signing.py index 38610b6ff..ae2248465 100644 --- a/google/cloud/storage/_signing.py +++ b/google/cloud/storage/_signing.py @@ -82,7 +82,7 @@ def get_signed_query_params_v2(credentials, expiration, string_to_sign): service_account_name = credentials.signer_email return { "GoogleAccessId": service_account_name, - "Expires": str(expiration), + "Expires": expiration, "Signature": signature, } @@ -384,7 +384,7 @@ def generate_signed_url_v2( signature = _sign_message(string_to_sign, access_token, service_account_email) signed_query_params = { "GoogleAccessId": service_account_email, - "Expires": str(expiration), + "Expires": expiration_stamp, "Signature": signature, } else: diff --git a/tests/unit/test__signing.py b/tests/unit/test__signing.py index 7b58a27dd..2907429a5 100644 --- a/tests/unit/test__signing.py +++ b/tests/unit/test__signing.py @@ -252,7 +252,7 @@ def test_it(self): expected = { "GoogleAccessId": account_name, - "Expires": str(expiration), + "Expires": expiration, "Signature": base64.b64encode(sig_bytes), } self.assertEqual(result, expected)