diff --git a/src/main/java/com/google/api/generator/gapic/composer/ServiceClientSampleCodeComposer.java b/src/main/java/com/google/api/generator/gapic/composer/ServiceClientSampleCodeComposer.java index 7c59ab5819..4f40f9fd71 100644 --- a/src/main/java/com/google/api/generator/gapic/composer/ServiceClientSampleCodeComposer.java +++ b/src/main/java/com/google/api/generator/gapic/composer/ServiceClientSampleCodeComposer.java @@ -21,9 +21,8 @@ import com.google.api.generator.engine.ast.ExprStatement; import com.google.api.generator.engine.ast.MethodInvocationExpr; import com.google.api.generator.engine.ast.Statement; -import com.google.api.generator.engine.ast.StringObjectValue; import com.google.api.generator.engine.ast.TypeNode; -import com.google.api.generator.engine.ast.ValueExpr; +import com.google.api.generator.engine.ast.VaporReference; import com.google.api.generator.engine.ast.Variable; import com.google.api.generator.engine.ast.VariableExpr; import com.google.api.generator.engine.writer.JavaWriterVisitor; @@ -44,6 +43,12 @@ public static String composeClassHeaderCredentialsSampleCode( // EchoSettings.newBuilder().setCredentialsProvider(FixedCredentialsProvider.create("myCredentials")).build(); String settingsName = JavaStyle.toLowerCamelCase(settingsType.reference().name()); String clientName = JavaStyle.toLowerCamelCase(clientType.reference().name()); + TypeNode myCredentialsType = + TypeNode.withReference( + VaporReference.builder() + .setName("myCredentials") + .setPakkage(clientType.reference().pakkage()) + .build()); VariableExpr settingsVarExpr = createVariableExpr(settingsName, settingsType); MethodInvocationExpr newBuilderMethodExpr = MethodInvocationExpr.builder() @@ -55,7 +60,7 @@ public static String composeClassHeaderCredentialsSampleCode( MethodInvocationExpr credentialArgExpr = MethodInvocationExpr.builder() .setStaticReferenceType(fixedCredentialProvideType) - .setArguments(ValueExpr.withValue(StringObjectValue.withValue("myCredentials"))) + .setArguments(createVariableExpr("myCredentials", myCredentialsType)) .setMethodName("create") .build(); MethodInvocationExpr credentialsMethodExpr = @@ -103,6 +108,12 @@ public static String composeClassHeaderEndpointSampleCode( // e.g. EchoSettings echoSettings = EchoSettings.newBuilder().setEndpoint("myEndpoint").build(); String settingsName = JavaStyle.toLowerCamelCase(settingsType.reference().name()); String clientName = JavaStyle.toLowerCamelCase(clientType.reference().name()); + TypeNode myEndpointType = + TypeNode.withReference( + VaporReference.builder() + .setName("myEndpoint") + .setPakkage(clientType.reference().pakkage()) + .build()); VariableExpr settingsVarExpr = createVariableExpr(settingsName, settingsType); MethodInvocationExpr newBuilderMethodExpr = MethodInvocationExpr.builder() @@ -112,7 +123,7 @@ public static String composeClassHeaderEndpointSampleCode( MethodInvocationExpr credentialsMethodExpr = MethodInvocationExpr.builder() .setExprReferenceExpr(newBuilderMethodExpr) - .setArguments(ValueExpr.withValue(StringObjectValue.withValue("myEndpoint"))) + .setArguments(createVariableExpr("myEndpoint", myEndpointType)) .setMethodName("setEndpoint") .build(); MethodInvocationExpr buildMethodExpr = diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClient.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClient.golden index 98a271a69a..04bc9131ff 100644 --- a/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClient.golden +++ b/src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClient.golden @@ -66,7 +66,7 @@ import javax.annotation.Generated; *
{@code
* EchoSettings echoSettings =
* EchoSettings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* EchoClient echoClient = EchoClient.create(echoSettings);
* }
@@ -74,7 +74,7 @@ import javax.annotation.Generated;
* To customize the endpoint: * *
{@code
- * EchoSettings echoSettings = EchoSettings.newBuilder().setEndpoint("myEndpoint").build();
+ * EchoSettings echoSettings = EchoSettings.newBuilder().setEndpoint(myEndpoint).build();
* EchoClient echoClient = EchoClient.create(echoSettings);
* }
*/
diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden
index 2ac3ee2add..3ad7f2617d 100644
--- a/src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden
+++ b/src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden
@@ -56,7 +56,7 @@ import javax.annotation.Generated;
* {@code
* IdentitySettings identitySettings =
* IdentitySettings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* IdentityClient identityClient = IdentityClient.create(identitySettings);
* }
@@ -65,7 +65,7 @@ import javax.annotation.Generated;
*
* {@code
* IdentitySettings identitySettings =
- * IdentitySettings.newBuilder().setEndpoint("myEndpoint").build();
+ * IdentitySettings.newBuilder().setEndpoint(myEndpoint).build();
* IdentityClient identityClient = IdentityClient.create(identitySettings);
* }
*/
diff --git a/test/integration/goldens/asset/AssetServiceClient.java b/test/integration/goldens/asset/AssetServiceClient.java
index b3d174be9f..77e8605e25 100644
--- a/test/integration/goldens/asset/AssetServiceClient.java
+++ b/test/integration/goldens/asset/AssetServiceClient.java
@@ -78,7 +78,7 @@
* {@code
* AssetServiceSettings assetServiceSettings =
* AssetServiceSettings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* AssetServiceClient assetServiceClient = AssetServiceClient.create(assetServiceSettings);
* }
@@ -87,7 +87,7 @@
*
* {@code
* AssetServiceSettings assetServiceSettings =
- * AssetServiceSettings.newBuilder().setEndpoint("myEndpoint").build();
+ * AssetServiceSettings.newBuilder().setEndpoint(myEndpoint).build();
* AssetServiceClient assetServiceClient = AssetServiceClient.create(assetServiceSettings);
* }
*/
diff --git a/test/integration/goldens/logging/ConfigServiceV2Client.java b/test/integration/goldens/logging/ConfigServiceV2Client.java
index 575980738f..c023def3b1 100644
--- a/test/integration/goldens/logging/ConfigServiceV2Client.java
+++ b/test/integration/goldens/logging/ConfigServiceV2Client.java
@@ -76,7 +76,7 @@
* {@code
* ConfigServiceV2Settings configServiceV2Settings =
* ConfigServiceV2Settings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* ConfigServiceV2Client configServiceV2Client =
* ConfigServiceV2Client.create(configServiceV2Settings);
@@ -86,7 +86,7 @@
*
* {@code
* ConfigServiceV2Settings configServiceV2Settings =
- * ConfigServiceV2Settings.newBuilder().setEndpoint("myEndpoint").build();
+ * ConfigServiceV2Settings.newBuilder().setEndpoint(myEndpoint).build();
* ConfigServiceV2Client configServiceV2Client =
* ConfigServiceV2Client.create(configServiceV2Settings);
* }
diff --git a/test/integration/goldens/logging/LoggingServiceV2Client.java b/test/integration/goldens/logging/LoggingServiceV2Client.java
index d50f10ebce..4a45a9bd3f 100644
--- a/test/integration/goldens/logging/LoggingServiceV2Client.java
+++ b/test/integration/goldens/logging/LoggingServiceV2Client.java
@@ -78,7 +78,7 @@
* {@code
* LoggingServiceV2Settings loggingServiceV2Settings =
* LoggingServiceV2Settings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* LoggingServiceV2Client loggingServiceV2Client =
* LoggingServiceV2Client.create(loggingServiceV2Settings);
@@ -88,7 +88,7 @@
*
* {@code
* LoggingServiceV2Settings loggingServiceV2Settings =
- * LoggingServiceV2Settings.newBuilder().setEndpoint("myEndpoint").build();
+ * LoggingServiceV2Settings.newBuilder().setEndpoint(myEndpoint).build();
* LoggingServiceV2Client loggingServiceV2Client =
* LoggingServiceV2Client.create(loggingServiceV2Settings);
* }
diff --git a/test/integration/goldens/logging/MetricsServiceV2Client.java b/test/integration/goldens/logging/MetricsServiceV2Client.java
index 09761c6979..6cd33bb8c4 100644
--- a/test/integration/goldens/logging/MetricsServiceV2Client.java
+++ b/test/integration/goldens/logging/MetricsServiceV2Client.java
@@ -75,7 +75,7 @@
* {@code
* MetricsServiceV2Settings metricsServiceV2Settings =
* MetricsServiceV2Settings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* MetricsServiceV2Client metricsServiceV2Client =
* MetricsServiceV2Client.create(metricsServiceV2Settings);
@@ -85,7 +85,7 @@
*
* {@code
* MetricsServiceV2Settings metricsServiceV2Settings =
- * MetricsServiceV2Settings.newBuilder().setEndpoint("myEndpoint").build();
+ * MetricsServiceV2Settings.newBuilder().setEndpoint(myEndpoint).build();
* MetricsServiceV2Client metricsServiceV2Client =
* MetricsServiceV2Client.create(metricsServiceV2Settings);
* }
diff --git a/test/integration/goldens/redis/CloudRedisClient.java b/test/integration/goldens/redis/CloudRedisClient.java
index d04354c29b..4dde5da5a4 100644
--- a/test/integration/goldens/redis/CloudRedisClient.java
+++ b/test/integration/goldens/redis/CloudRedisClient.java
@@ -98,7 +98,7 @@
* {@code
* CloudRedisSettings cloudRedisSettings =
* CloudRedisSettings.newBuilder()
- * .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
+ * .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
* .build();
* CloudRedisClient cloudRedisClient = CloudRedisClient.create(cloudRedisSettings);
* }
@@ -107,7 +107,7 @@
*
* {@code
* CloudRedisSettings cloudRedisSettings =
- * CloudRedisSettings.newBuilder().setEndpoint("myEndpoint").build();
+ * CloudRedisSettings.newBuilder().setEndpoint(myEndpoint).build();
* CloudRedisClient cloudRedisClient = CloudRedisClient.create(cloudRedisSettings);
* }
*/