diff --git a/src/main/java/com/google/api/generator/gapic/composer/GrpcServiceStubClassComposer.java b/src/main/java/com/google/api/generator/gapic/composer/GrpcServiceStubClassComposer.java index f05a0e057d..8537d1a4a7 100644 --- a/src/main/java/com/google/api/generator/gapic/composer/GrpcServiceStubClassComposer.java +++ b/src/main/java/com/google/api/generator/gapic/composer/GrpcServiceStubClassComposer.java @@ -934,6 +934,7 @@ private static List createCallableGetterMethods( .map( e -> MethodDefinition.builder() + .setIsOverride(true) .setScope(ScopeNode.PUBLIC) .setReturnType(e.getValue().type()) .setName(e.getKey()) diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcEchoStub.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcEchoStub.golden index 3c32fbab4f..194849ba09 100644 --- a/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcEchoStub.golden +++ b/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcEchoStub.golden @@ -256,51 +256,63 @@ public class GrpcEchoStub extends EchoStub { return operationsStub; } + @Override public UnaryCallable echoCallable() { return echoCallable; } + @Override public ServerStreamingCallable expandCallable() { return expandCallable; } + @Override public ClientStreamingCallable collectCallable() { return collectCallable; } + @Override public BidiStreamingCallable chatCallable() { return chatCallable; } + @Override public BidiStreamingCallable chatAgainCallable() { return chatAgainCallable; } + @Override public UnaryCallable pagedExpandCallable() { return pagedExpandCallable; } + @Override public UnaryCallable pagedExpandPagedCallable() { return pagedExpandPagedCallable; } + @Override public UnaryCallable simplePagedExpandCallable() { return simplePagedExpandCallable; } + @Override public UnaryCallable simplePagedExpandPagedCallable() { return simplePagedExpandPagedCallable; } + @Override public UnaryCallable waitCallable() { return waitCallable; } + @Override public OperationCallable waitOperationCallable() { return waitOperationCallable; } + @Override public UnaryCallable blockCallable() { return blockCallable; } diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcPublisherStub.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcPublisherStub.golden index 72fc5eff63..9e221ab5a2 100644 --- a/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcPublisherStub.golden +++ b/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcPublisherStub.golden @@ -363,54 +363,66 @@ public class GrpcPublisherStub extends PublisherStub { return operationsStub; } + @Override public UnaryCallable createTopicCallable() { return createTopicCallable; } + @Override public UnaryCallable updateTopicCallable() { return updateTopicCallable; } + @Override public UnaryCallable publishCallable() { return publishCallable; } + @Override public UnaryCallable getTopicCallable() { return getTopicCallable; } + @Override public UnaryCallable listTopicsCallable() { return listTopicsCallable; } + @Override public UnaryCallable listTopicsPagedCallable() { return listTopicsPagedCallable; } + @Override public UnaryCallable listTopicSubscriptionsCallable() { return listTopicSubscriptionsCallable; } + @Override public UnaryCallable listTopicSubscriptionsPagedCallable() { return listTopicSubscriptionsPagedCallable; } + @Override public UnaryCallable listTopicSnapshotsCallable() { return listTopicSnapshotsCallable; } + @Override public UnaryCallable listTopicSnapshotsPagedCallable() { return listTopicSnapshotsPagedCallable; } + @Override public UnaryCallable deleteTopicCallable() { return deleteTopicCallable; } + @Override public UnaryCallable detachSubscriptionCallable() { return detachSubscriptionCallable; diff --git a/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcTestingStub.golden b/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcTestingStub.golden index 5c6a4e4626..b1d8da085a 100644 --- a/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcTestingStub.golden +++ b/src/test/java/com/google/api/generator/gapic/composer/goldens/GrpcTestingStub.golden @@ -324,46 +324,57 @@ public class GrpcTestingStub extends TestingStub { return operationsStub; } + @Override public UnaryCallable createSessionCallable() { return createSessionCallable; } + @Override public UnaryCallable getSessionCallable() { return getSessionCallable; } + @Override public UnaryCallable listSessionsCallable() { return listSessionsCallable; } + @Override public UnaryCallable listSessionsPagedCallable() { return listSessionsPagedCallable; } + @Override public UnaryCallable deleteSessionCallable() { return deleteSessionCallable; } + @Override public UnaryCallable reportSessionCallable() { return reportSessionCallable; } + @Override public UnaryCallable getTestCallable() { return getTestCallable; } + @Override public UnaryCallable listTestsCallable() { return listTestsCallable; } + @Override public UnaryCallable listTestsPagedCallable() { return listTestsPagedCallable; } + @Override public UnaryCallable deleteTestCallable() { return deleteTestCallable; } + @Override public UnaryCallable verifyTestCallable() { return verifyTestCallable; } diff --git a/test/integration/goldens/asset/GrpcAssetServiceStub.java b/test/integration/goldens/asset/GrpcAssetServiceStub.java index b613cceb4e..baaefdd441 100644 --- a/test/integration/goldens/asset/GrpcAssetServiceStub.java +++ b/test/integration/goldens/asset/GrpcAssetServiceStub.java @@ -385,55 +385,67 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable exportAssetsCallable() { return exportAssetsCallable; } + @Override public OperationCallable exportAssetsOperationCallable() { return exportAssetsOperationCallable; } + @Override public UnaryCallable batchGetAssetsHistoryCallable() { return batchGetAssetsHistoryCallable; } + @Override public UnaryCallable createFeedCallable() { return createFeedCallable; } + @Override public UnaryCallable getFeedCallable() { return getFeedCallable; } + @Override public UnaryCallable listFeedsCallable() { return listFeedsCallable; } + @Override public UnaryCallable updateFeedCallable() { return updateFeedCallable; } + @Override public UnaryCallable deleteFeedCallable() { return deleteFeedCallable; } + @Override public UnaryCallable searchAllResourcesCallable() { return searchAllResourcesCallable; } + @Override public UnaryCallable searchAllResourcesPagedCallable() { return searchAllResourcesPagedCallable; } + @Override public UnaryCallable searchAllIamPoliciesCallable() { return searchAllIamPoliciesCallable; } + @Override public UnaryCallable searchAllIamPoliciesPagedCallable() { return searchAllIamPoliciesPagedCallable; diff --git a/test/integration/goldens/credentials/GrpcIamCredentialsStub.java b/test/integration/goldens/credentials/GrpcIamCredentialsStub.java index 869e84c892..55cc0068d5 100644 --- a/test/integration/goldens/credentials/GrpcIamCredentialsStub.java +++ b/test/integration/goldens/credentials/GrpcIamCredentialsStub.java @@ -216,19 +216,23 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable generateAccessTokenCallable() { return generateAccessTokenCallable; } + @Override public UnaryCallable generateIdTokenCallable() { return generateIdTokenCallable; } + @Override public UnaryCallable signBlobCallable() { return signBlobCallable; } + @Override public UnaryCallable signJwtCallable() { return signJwtCallable; } diff --git a/test/integration/goldens/library/GrpcLibraryServiceStub.java b/test/integration/goldens/library/GrpcLibraryServiceStub.java index 90f7a9a613..c2d424a93a 100644 --- a/test/integration/goldens/library/GrpcLibraryServiceStub.java +++ b/test/integration/goldens/library/GrpcLibraryServiceStub.java @@ -383,54 +383,67 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable createShelfCallable() { return createShelfCallable; } + @Override public UnaryCallable getShelfCallable() { return getShelfCallable; } + @Override public UnaryCallable listShelvesCallable() { return listShelvesCallable; } + @Override public UnaryCallable listShelvesPagedCallable() { return listShelvesPagedCallable; } + @Override public UnaryCallable deleteShelfCallable() { return deleteShelfCallable; } + @Override public UnaryCallable mergeShelvesCallable() { return mergeShelvesCallable; } + @Override public UnaryCallable createBookCallable() { return createBookCallable; } + @Override public UnaryCallable getBookCallable() { return getBookCallable; } + @Override public UnaryCallable listBooksCallable() { return listBooksCallable; } + @Override public UnaryCallable listBooksPagedCallable() { return listBooksPagedCallable; } + @Override public UnaryCallable deleteBookCallable() { return deleteBookCallable; } + @Override public UnaryCallable updateBookCallable() { return updateBookCallable; } + @Override public UnaryCallable moveBookCallable() { return moveBookCallable; } diff --git a/test/integration/goldens/logging/GrpcConfigServiceV2Stub.java b/test/integration/goldens/logging/GrpcConfigServiceV2Stub.java index 21515b9731..1516b53b47 100644 --- a/test/integration/goldens/logging/GrpcConfigServiceV2Stub.java +++ b/test/integration/goldens/logging/GrpcConfigServiceV2Stub.java @@ -532,75 +532,93 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable listBucketsCallable() { return listBucketsCallable; } + @Override public UnaryCallable listBucketsPagedCallable() { return listBucketsPagedCallable; } + @Override public UnaryCallable getBucketCallable() { return getBucketCallable; } + @Override public UnaryCallable updateBucketCallable() { return updateBucketCallable; } + @Override public UnaryCallable listSinksCallable() { return listSinksCallable; } + @Override public UnaryCallable listSinksPagedCallable() { return listSinksPagedCallable; } + @Override public UnaryCallable getSinkCallable() { return getSinkCallable; } + @Override public UnaryCallable createSinkCallable() { return createSinkCallable; } + @Override public UnaryCallable updateSinkCallable() { return updateSinkCallable; } + @Override public UnaryCallable deleteSinkCallable() { return deleteSinkCallable; } + @Override public UnaryCallable listExclusionsCallable() { return listExclusionsCallable; } + @Override public UnaryCallable listExclusionsPagedCallable() { return listExclusionsPagedCallable; } + @Override public UnaryCallable getExclusionCallable() { return getExclusionCallable; } + @Override public UnaryCallable createExclusionCallable() { return createExclusionCallable; } + @Override public UnaryCallable updateExclusionCallable() { return updateExclusionCallable; } + @Override public UnaryCallable deleteExclusionCallable() { return deleteExclusionCallable; } + @Override public UnaryCallable getCmekSettingsCallable() { return getCmekSettingsCallable; } + @Override public UnaryCallable updateCmekSettingsCallable() { return updateCmekSettingsCallable; } diff --git a/test/integration/goldens/logging/GrpcLoggingServiceV2Stub.java b/test/integration/goldens/logging/GrpcLoggingServiceV2Stub.java index d498e6f9f8..671ea68695 100644 --- a/test/integration/goldens/logging/GrpcLoggingServiceV2Stub.java +++ b/test/integration/goldens/logging/GrpcLoggingServiceV2Stub.java @@ -251,39 +251,47 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable deleteLogCallable() { return deleteLogCallable; } + @Override public UnaryCallable writeLogEntriesCallable() { return writeLogEntriesCallable; } + @Override public UnaryCallable listLogEntriesCallable() { return listLogEntriesCallable; } + @Override public UnaryCallable listLogEntriesPagedCallable() { return listLogEntriesPagedCallable; } + @Override public UnaryCallable< ListMonitoredResourceDescriptorsRequest, ListMonitoredResourceDescriptorsResponse> listMonitoredResourceDescriptorsCallable() { return listMonitoredResourceDescriptorsCallable; } + @Override public UnaryCallable< ListMonitoredResourceDescriptorsRequest, ListMonitoredResourceDescriptorsPagedResponse> listMonitoredResourceDescriptorsPagedCallable() { return listMonitoredResourceDescriptorsPagedCallable; } + @Override public UnaryCallable listLogsCallable() { return listLogsCallable; } + @Override public UnaryCallable listLogsPagedCallable() { return listLogsPagedCallable; } diff --git a/test/integration/goldens/logging/GrpcMetricsServiceV2Stub.java b/test/integration/goldens/logging/GrpcMetricsServiceV2Stub.java index 0bb3e1b866..10507c44cd 100644 --- a/test/integration/goldens/logging/GrpcMetricsServiceV2Stub.java +++ b/test/integration/goldens/logging/GrpcMetricsServiceV2Stub.java @@ -246,27 +246,33 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable listLogMetricsCallable() { return listLogMetricsCallable; } + @Override public UnaryCallable listLogMetricsPagedCallable() { return listLogMetricsPagedCallable; } + @Override public UnaryCallable getLogMetricCallable() { return getLogMetricCallable; } + @Override public UnaryCallable createLogMetricCallable() { return createLogMetricCallable; } + @Override public UnaryCallable updateLogMetricCallable() { return updateLogMetricCallable; } + @Override public UnaryCallable deleteLogMetricCallable() { return deleteLogMetricCallable; } diff --git a/test/integration/goldens/redis/GrpcCloudRedisStub.java b/test/integration/goldens/redis/GrpcCloudRedisStub.java index 416417d996..99f15a59c6 100644 --- a/test/integration/goldens/redis/GrpcCloudRedisStub.java +++ b/test/integration/goldens/redis/GrpcCloudRedisStub.java @@ -415,73 +415,90 @@ public GrpcOperationsStub getOperationsStub() { return operationsStub; } + @Override public UnaryCallable listInstancesCallable() { return listInstancesCallable; } + @Override public UnaryCallable listInstancesPagedCallable() { return listInstancesPagedCallable; } + @Override public UnaryCallable getInstanceCallable() { return getInstanceCallable; } + @Override public UnaryCallable createInstanceCallable() { return createInstanceCallable; } + @Override public OperationCallable createInstanceOperationCallable() { return createInstanceOperationCallable; } + @Override public UnaryCallable updateInstanceCallable() { return updateInstanceCallable; } + @Override public OperationCallable updateInstanceOperationCallable() { return updateInstanceOperationCallable; } + @Override public UnaryCallable upgradeInstanceCallable() { return upgradeInstanceCallable; } + @Override public OperationCallable upgradeInstanceOperationCallable() { return upgradeInstanceOperationCallable; } + @Override public UnaryCallable importInstanceCallable() { return importInstanceCallable; } + @Override public OperationCallable importInstanceOperationCallable() { return importInstanceOperationCallable; } + @Override public UnaryCallable exportInstanceCallable() { return exportInstanceCallable; } + @Override public OperationCallable exportInstanceOperationCallable() { return exportInstanceOperationCallable; } + @Override public UnaryCallable failoverInstanceCallable() { return failoverInstanceCallable; } + @Override public OperationCallable failoverInstanceOperationCallable() { return failoverInstanceOperationCallable; } + @Override public UnaryCallable deleteInstanceCallable() { return deleteInstanceCallable; } + @Override public OperationCallable deleteInstanceOperationCallable() { return deleteInstanceOperationCallable; }