Skip to content

core(emulation): remove use of deprecated Emulation.setVisibleSize#3536

Merged
brendankenny merged 1 commit intomasterfrom
nosetvisiblesize
Oct 13, 2017
Merged

core(emulation): remove use of deprecated Emulation.setVisibleSize#3536
brendankenny merged 1 commit intomasterfrom
nosetvisiblesize

Conversation

@paulirish
Copy link
Member

This protocol method was made redundant in 61.0.3155.0

It's a noop for us now. Trace screenshots are no different.

fixes #2831

@patrickhulce
Copy link
Collaborator

Is 61 fully out now? It's been pretty slow going

@paulirish
Copy link
Member Author

Is 61 fully out now? It's been pretty slow going

Shipped on sept 5th!
stable is really only a concern for our extension users, but not our devtools people. and typically not CLI, though we don't know for sure.

chrome doesn't support stable-1 releases and i don't think we should either. 😀

Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@brendankenny brendankenny merged commit ecbbc38 into master Oct 13, 2017
@brendankenny brendankenny deleted the nosetvisiblesize branch October 13, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not use Emulation.setVisibleSize

3 participants