core(image-aspect-ratio): pass audit when no images are missized#3552
Merged
brendankenny merged 2 commits intomasterfrom Oct 13, 2017
Merged
core(image-aspect-ratio): pass audit when no images are missized#3552brendankenny merged 2 commits intomasterfrom
brendankenny merged 2 commits intomasterfrom
Conversation
add smoke test for audit
brendankenny
commented
Oct 13, 2017
| value: { | ||
| results: { | ||
| length: 14, | ||
| length: 15, |
Contributor
Author
There was a problem hiding this comment.
additional request for image in page
brendankenny
commented
Oct 13, 2017
| }, | ||
| }, | ||
| }, | ||
| 'image-aspect-ratio': { |
Contributor
Author
There was a problem hiding this comment.
dbw seemed like the best place for this since it's already running all of Best Practices, but happy to move
patrickhulce
approved these changes
Oct 13, 2017
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks for fixing!
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add smoke test for audit
fixes #3551