Conversation
Collaborator
|
👍 I'll put all new audits into the default config from now on. |
Member
|
👍 thanks @brendankenny! |
rviscomi
approved these changes
Oct 17, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3521
These audit results will show up in the
auditsobject on the LHR, but won't show up in the HTML report as no category includes them. They will be filtered out by any config that subsets the default config because of this, however.We can add the other SEO audits as they land (probably as long as they don't have substantial cost) and/or make them visible in the report by bringing in the SEO report category if we're ready.
@kdzwinel @rviscomi