misc(jsconfig): Enable type checking for JavaScript#3589
Merged
paulirish merged 2 commits intoGoogleChrome:masterfrom Oct 17, 2017
Merged
misc(jsconfig): Enable type checking for JavaScript#3589paulirish merged 2 commits intoGoogleChrome:masterfrom
paulirish merged 2 commits intoGoogleChrome:masterfrom
Conversation
Contributor
obvs this is non-binding for now, but this seems like a good idea. If we have type checking some day we'll want to be strict with nulls/undefined |
Collaborator
Author
|
@brendankenny 👍 added |
paulirish
approved these changes
Oct 17, 2017
patrickhulce
approved these changes
Oct 17, 2017
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice 👍
I'd guess strict does something similar to ts's strict which is just an alias for a couple useful flags?
--strictNullChecks
--noImplicitAny
--noImplicitThis
--alwaysStrict
https://blog.mariusschulz.com/2017/06/09/typescript-2-3-the-strict-compiler-option
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights errors in IDE, doesn't affect automatic linters.
Doc: https://code.visualstudio.com/docs/languages/javascript (cmd+f "checkJs")
Can be disabled per file via
// @ts-nocheck.We could also add
strict: true. I have hard time finding the docs for this, but from what I can see it doesn't allow implicit 'any' type and is able to recognize that function may return undefined while jsdoc says it should return a string.