tests(smokehouse): disable multiple shadow root deprecation test#3695
Merged
brendankenny merged 1 commit intomasterfrom Oct 31, 2017
Merged
tests(smokehouse): disable multiple shadow root deprecation test#3695brendankenny merged 1 commit intomasterfrom
brendankenny merged 1 commit intomasterfrom
Conversation
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken appveyor tests.
In m64 the multiple shadow root deprecation warning has turned into an error, so
deprecations--anderrors-in-console++. However, Travis runs stable while Appveyor runs Canary, so there's no great way to get these two to play along nicely short of just disabling that particular error indbw_testeruntil m64 hits stable (which is what this does).I investigated checking the
details.itemsstrings more directly (something we should probably do more often rather than just checkinglength), which would allow only checking a subset ofitemsand ignoring the shadow root error in either list, but since these two audits' results are sorted by the order the error messages are emitted in, they weren't listed in a reliable order and so can't be addressed by index.