misc: use undated Apache 2 LICENSE file#3700
Merged
brendankenny merged 2 commits intomasterfrom Nov 10, 2017
Merged
Conversation
Contributor
brendankenny
left a comment
There was a problem hiding this comment.
ha, weirdly spotted :)
But isn't this line just supposed to be the boilerplate Copyright [yyyy] [name of copyright owner], since it's just the license giving general info on how it's used, not us giving info on how to use the license on our project?
Contributor
Author
|
You're supposed to append to the generic license and modify it with your own info: |
Contributor
|
right, but it's telling you how to do that when attaching that header to your work, not to do it to the text below. The internet seems mixed on this, but most of the Apache projects seem to do it this way, and presumably they know how to do it right (e.g. couchdb, though notably this one does not) |
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.