core(meta-tag-gatherers): meta tag search should be case-insensitive#3729
Merged
patrickhulce merged 2 commits intoGoogleChrome:masterfrom Nov 6, 2017
Merged
Conversation
Collaborator
kdzwinel
commented
Nov 2, 2017
kdzwinel
commented
patrickhulce
suggested changes
Nov 2, 2017
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice! want to change one of the smoke tests to catch this failure case?
Collaborator
Author
|
@patrickhulce good point! I've updated one of my previous tests (and somehow pulled @brendankenny into this - sorry!). |
patrickhulce
approved these changes
Nov 2, 2017
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
great catch @kdzwinel thanks for fixing!
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
…oogleChrome#3729) * Metatag search should be case-insensitive * Modify SEO smoke test to test case-insenstive meta tags
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.