core(predictive-perf): predict FCP#3730
Merged
patrickhulce merged 3 commits intomasterfrom Nov 9, 2017
Merged
Conversation
Collaborator
Author
I'm inclined to reduce churn in exposing until we have a concrete plan for what we expose ala #3761, but I agree so I changed to just add FCP and not touch FMP |
78875e9 to
8b0f2b9
Compare
brendankenny
approved these changes
Nov 7, 2017
Contributor
brendankenny
left a comment
There was a problem hiding this comment.
This all looks good to me.
As we were talking about, maybe add extendedInfo entries for first approximations at estimates, even if they're only in the ballpark of where we're going with this? Happy to go with awkward names that discourage treating them as more than placeholders :)
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
* core(predictive-perf): predict FCP instead of FMP * add back FMP * add rough estimates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3671
closes #3593
Adds prediction of FCP, similar to FMP but move the time boundary to observed FCP, remove the CPU layout tasks, and add in the EvaluateScript tasks of blocking scripts (which really could have been part of FMP prediction too).
I also added redirects support since FCP was more radically impacted by missing redirect support than FMP was. I dug into a lot of the larger error cases (where error was >1s) and at this point small differences should not be used for decision making.
Some notable examples:
Overall, we're about as accurate as we were with FMP, higher error at the tail but lower error for most sites. Further progress on accuracy will need higher fidelity throttling like WPT.
Accuracy comparison