Skip to content

core(driver): increase default timeout to 45s#3741

Merged
brendankenny merged 1 commit intomasterfrom
increase_timeout
Nov 7, 2017
Merged

core(driver): increase default timeout to 45s#3741
brendankenny merged 1 commit intomasterfrom
increase_timeout

Conversation

@patrickhulce
Copy link
Collaborator

closes #3733

things to consider:

  • this might break folks who were running on bad hardware and needed to keep traces small (counter: it currently breaks for plenty of these sites at 30s already)
  • scores will change from 0 to ~8 at sites with TTI at 30s

@vinamratasingal-zz
Copy link

Huge fan of this- increasing timeouts will (I think) reduce our error rates.

Copy link
Contributor

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@brendankenny
Copy link
Contributor

we got a verbal 👍 from @paulirish so let's do this!

@brendankenny brendankenny merged commit 8a1af52 into master Nov 7, 2017
@brendankenny brendankenny deleted the increase_timeout branch November 7, 2017 19:15
christhompson pushed a commit to christhompson/lighthouse that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Core: increase page load timeout to 45s

4 participants