Merged
Conversation
patrickhulce
requested review from
brendankenny,
paulirish and
vinamratasingal-zz
as code owners
patrickhulce
commented
Nov 7, 2017
| | extendedInfo | `Object` | Extra information found by the audit. The structure of this object varies from audit to audit and is generally for programmatic consumption and debugging, though there is typically overlap with `details`. *WARNING: The structure of this object is not stable and cannot be trusted to follow semver* | | ||
| | manual | `boolean` | Indicator used for display that the audit does not have results and is a placeholder for the user to conduct manual testing. | | ||
| | informative | `boolean` | Indicator used for display that the audit is intended to be informative only. It cannot be passed or failed. | | ||
| | category | `string` | No longer used. *WARNING: Deprecated, will be removed in Lighthouse 3.0* | |
Collaborator
Author
There was a problem hiding this comment.
This should've been cleaned up when category was removed, no references to optimalValue since we didn't want anyone to use it :)
brendankenny
approved these changes
Nov 10, 2017
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
target: > LGTM
🔔 🙌 🎉
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2812
I'd normally oppose removing this without a major version bump, but the value was almost always an english string like
< 1,000rather than a number that people likely relied on, we also just removed the similarly uselesscategoryproperty without a major bump so blocking this seems inconsistentI kept the existing target references in dom-size audit since those are explicitly in the description as to why you care and its just for making sense of the data in the cards. Still removed the overall optimalValue display.