cli: do not double quote chromeFlags

[patrickhulce]

closes #3744

[brendankenny]

dd27317#r140888688

:)

So basically it's taken care of since spawn passes in arguments as an array, so they don't need their values quoted? Or something else? This is confusing because the fix in #2754 needed quotes, but maybe the spawn method or our handling of chromeFlags has changed since then.

I tried out the problem case from that PR (--chrome-flags="--user-agent=\"iPhone Test\"") and it works just fine with this PR.

👍 for the explanatory comment, but maybe the tests can do with some cleaning up? Some repetition now and not all the descriptions match up to their test (e.g. quotes flag values with spaces in them)

[patrickhulce]

Link just takes me to the commit so not entirely sure if you're talking about #3408 (comment), but the short story here is that quoting any value is indeed bad, not that quoting single words is bad but spaced values is fine.

So basically it's taken care of since spawn passes in arguments as an array, so they don't need their values quoted?

Correct

This is confusing because the fix in #2754 needed quotes, but maybe the spawn method or our handling of chromeFlags has changed since then.

Nothing has changed, but it is confusing. #2754 was about us needing to respect quoted values when parsing because we just did a basic s.split(' '). This issue is about us needing to not add superfluous quotes when sending along the parsed values.

All of this would go away if we weren't using spawn and just doing a shell chrome ${theRawFlags}, but because we parse and pass as array it raises all these problems

maybe the tests can do with some cleaning up?

ya done

[brendankenny]

LGTM

[brendankenny]

appveyor is being dumb missing that offscreen svg again. Ignoring for now

[hirokith]

When could this merge be published? I've encountered the --user-data-dir wrapped with quotes, which breaks my program.