core(image-usage): add null check for parentElement#3779
Merged
patrickhulce merged 5 commits intoGoogleChrome:masterfrom Nov 8, 2017
Merged
core(image-usage): add null check for parentElement#3779patrickhulce merged 5 commits intoGoogleChrome:masterfrom
patrickhulce merged 5 commits intoGoogleChrome:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Collaborator
|
@AkshayIyer12 Thanks for fixing this bug! Do you have a webpage where this audit fails? is it possible to create a unit test for this one? |
Collaborator
patrickhulce
approved these changes
Nov 8, 2017
Collaborator
patrickhulce
left a comment
There was a problem hiding this comment.
thanks for taking this on @AkshayIyer12 !! 🎉
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
* core(image-usage): add null check for parentElement * core(image-usage): add null check for parentElement * add smoke test * add issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.