tests(smoke): add long task to byte-efficiency tester to deflake appveyor#3804
Merged
patrickhulce merged 1 commit intomasterfrom Nov 13, 2017
Merged
tests(smoke): add long task to byte-efficiency tester to deflake appveyor#3804patrickhulce merged 1 commit intomasterfrom
patrickhulce merged 1 commit intomasterfrom
Conversation
Collaborator
|
appveyor still failed, but for FMP being <90 on online-only tester, geez how slow are these vms its literally a single node with some text! |
patrickhulce
approved these changes
Nov 13, 2017
|
Vvms is slow of shit... |
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
large.svgstarts loading almost exactly at FI on appveyor, leading to it to be pretty flakey sinceoffscreen-imagesdoesn't count images that start loading after FI. This PR just adds an artificial long task to push FI out a few more seconds to deflake things.So far it's been passing consistently on appveyor over a few loads; will rerun multiple more times.
Also: since the
extendedInfois sorted by image size, added more useful expectations using the image file names, which should hopefully make the diff a little clearer for any future errors.