cli(sentry): handle configstore errors by not enabling error reporting#3878
Merged
brendankenny merged 1 commit intomasterfrom Nov 21, 2017
Merged
cli(sentry): handle configstore errors by not enabling error reporting#3878brendankenny merged 1 commit intomasterfrom
brendankenny merged 1 commit intomasterfrom
Conversation
brendankenny
requested review from
patrickhulce and
paulirish
as code owners
patrickhulce
approved these changes
Nov 21, 2017
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
seems like a good call 👍
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3873
Lighthouse shouldn't fail when
configstorehits anEACCESerror. We also don't want to make a user who can't useconfigstorehit the 20 second timeout every time, so it seems like defaulting to false is the thing to do here.Seemed better to have this handled within
askPermissionthan by the caller. Promise wrapper will get a bit nicer when we can do async/await, but note that it's thegetandsetcalls that try to access the file, not theConfigstoreconstructor, and wrapping the two individually made a bit of a mess.