deps: Bump ws to 3.3.2#3949
Merged
paulirish merged 1 commit intoGoogleChrome:masterfrom Nov 30, 2017
crimeminister:fix/bump-dependency-ws
Merged
deps: Bump ws to 3.3.2#3949paulirish merged 1 commit intoGoogleChrome:masterfrom crimeminister:fix/bump-dependency-ws
paulirish merged 1 commit intoGoogleChrome:masterfrom
crimeminister:fix/bump-dependency-ws
Conversation
Remediate security vulnerability in ws@1.1.2 by updating to recent version. Cf. https://nodesecurity.io/advisories/550
patrickhulce
approved these changes
Nov 29, 2017
Collaborator
There was a problem hiding this comment.
went through the breaking changes since 1.x and didn't seem like we were using any of them, so lgtm! 👍
thanks again for finding and fixing @crimeminister! 🎉
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remediate security vulnerability in
ws@1.1.2by updating to recent version. Here is the security advisory.closes #3948