core(uses-webp): tweak text to be more next-gen focused#3985
core(uses-webp): tweak text to be more next-gen focused#3985patrickhulce merged 4 commits intomasterfrom
Conversation
| description: 'Serve images in next-gen formats', | ||
| informative: true, | ||
| helpText: 'WebP provides better lossy and lossless compression than PNG or JPEG, ' + | ||
| helpText: 'JP2, JPEG XR, and WebP often provide better compression than PNG or JPEG, ' + |
There was a problem hiding this comment.
let's use the elongated names
Image formats like JPEG 2000, JPEG XR, and WebP often provide better compression than PNG or JPEG
There was a problem hiding this comment.
Passing comment: as part of the research we did for images.guide, it turned out that a lot of users could get some pretty hefty wins from adopted MozJPEG. This isn't technically a next-gen format, but a JPEG optimizer. Unsure if you'd want to cater for those types of recommendations.
| return { | ||
| name: 'uses-webp-images', | ||
| description: 'Serve images as WebP', | ||
| description: 'Serve images in next-gen formats', |
There was a problem hiding this comment.
I'm wondering if there's a better name than "next-gen". The closest i'm getting is "2010-era". But that doesnt' seem worth it.
There was a problem hiding this comment.
how about just "better" or "superior"?
patrickhulce
force-pushed
the
rename_webp
branch
from
e11fd33 to
f17348e
Compare
|
WFM. over to @vinamratasingal as this is user facing |
vinamratasingal-zz
left a comment
vinamratasingal-zz
left a comment
There was a problem hiding this comment.
That table looks dope. We should add that to the docs!
Thanks for tagging me Paul- looks good, just have a few followup comments :)
| return { | ||
| name: 'uses-webp-images', | ||
| description: 'Serve images as WebP', | ||
| description: 'Serve images in superior formats', |
There was a problem hiding this comment.
"Superior formats" seems a little judgy. Can we just say "next-gen formats" or "performant formats"
There was a problem hiding this comment.
'next-gen' was nixed, but performant SGTM
There was a problem hiding this comment.
nevermind paul's good with "next-gen" afterall 👍
| 'which means faster downloads and less data consumption. ' + | ||
| helpText: 'Image formats like JPEG 2000, JPEG XR, and WebP often provide better ' + | ||
| 'compression than PNG or JPEG, which means faster downloads and less data consumption. ' + | ||
| '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/webp).', |
There was a problem hiding this comment.
Shouldn't we update this documentation to explain the different formats?
There was a problem hiding this comment.
Yes, indeed we should
There was a problem hiding this comment.
Filed a bug against Kayce to update the docs for next sprint :)
There was a problem hiding this comment.
Cool cool, I also just got a brain dump from him on how I can update stuff and seems straightforward when we have changes to docs like this that aren't new material :)
| informative: true, | ||
| helpText: 'WebP provides better lossy and lossless compression than PNG or JPEG, ' + | ||
| 'which means faster downloads and less data consumption. ' + | ||
| helpText: 'Image formats like JPEG 2000, JPEG XR, and WebP often provide better ' + |
There was a problem hiding this comment.
Do you want to mention something here about different browser support for each, or nah?
There was a problem hiding this comment.
Nah we have a policy to keep the details in the docs
|
👍 |
ghost
mentioned this pull request
5 participants
closes #3557