core(extension): extract a new ext-bg file, splitting extn/devtools usecases#4162
Merged
patrickhulce merged 2 commits intomasterfrom Jan 3, 2018
Merged
core(extension): extract a new ext-bg file, splitting extn/devtools usecases#4162patrickhulce merged 2 commits intomasterfrom
patrickhulce merged 2 commits intomasterfrom
Conversation
paulirish
changed the title
Member
Author
|
After these two PRs, the total lighthouse-background file size drops from 2.75MB to 2.56MB. (which is 7.42% smaller). This is pre-minify, pre-gzip size. bundlesize sez this about the post-minify, post-gzip size: And obviously this also means that we have two compiled files:
I'm open to other filenames if we want to bikeshed that. |
paulirish
force-pushed
the
extract-lh-ext-bg
branch
from
71e80a4 to
ec8f444
Compare
Collaborator
|
FYI @jianzhoufeng LRider will need to use the lighthouse-ext-background moving forward after this change |
Contributor
|
Got it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cut-paste job except for:
updateBadgeFnpassed as arg intorunLighthouseForConnectionlighthouseIsRunningis set within theupdateBadgeUImethod nowfixes #2014 (along with #4161)