report: more attractive table/URL rendering#4190
Conversation
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice! so good
do you know how this impacts cells that are in the url column but are actually other types like code? i'm thinking of the css usage audit in particular
| element.appendChild(this._renderText({ | ||
| text: displayedPath, | ||
| })); | ||
| const hostElem = this._renderText({ |
There was a problem hiding this comment.
does this need to be conditional on displayedHost?
|
|
||
| const MAX_LENGTH = 64; | ||
| // Always elide hash | ||
| // Always elide git hash |
There was a problem hiding this comment.
how about just hex hash :)
| // Also elide long number sequences | ||
| name = name.replace(/(\d{3})\d{6,}/g, `$1${ELLIPSIS}`); | ||
| // Merge any adjacent ellipses | ||
| name = name.replace(/\u2026+/g, '\u2026'); |
There was a problem hiding this comment.
\u2026 is ellipsis right, so just pass ELLIPSIS here like the others? :)
paulirish
force-pushed
the
bettertables
branch
from
c66a63b to
c54014a
Compare
good call!! it wasn't ideal. but after some fixes:
updated. |
|
awaiting CI results. when green, land away. |
|
geez since when did "Unable to connect to Chrome" start failing 100% of the time?? |
3 participants
Before and after
partial fix for #3827 but its not totally complete.