deps(chrome-launcher): Upgrade chrome-launcher#4192
Conversation
|
ruh roh. looks like i did indeed break the TS typings with the folder move: GoogleChrome/chrome-launcher#69 (comment) |
51eb685 to
92e9105
Compare
|
just rebased to get the #4209 fix that was breaking this PR. why was it breaking this PR out of the blue? that, we'll never know. 🐩 |
|
Is there a test we could add to chrome-launcher to prevent this? |
yes i would love that. not how to write it, personally. you might know better than most of us. :) |
|
Not 100% sure but we can write a test like this: By default it checks in the root directory |
|
i was thinking a more functional test. e.g. some module that require()s chrome-launcher successfully typechecks with TS. filed as GoogleChrome/chrome-launcher#83 |
|
even though travis is busted, appveyor is happy. shipping. |

Upgrade chrome-launcher to 0.10.1.
I wasn't sure why chrome-launcher does not have a
^in package.json so feel free to decline this PR.