core(audit): Add 10ms threshold to bootup-time audits#4223
Merged
Conversation
patrickhulce
reviewed
Jan 9, 2018
| const results = Array.from(executionTimings) | ||
| .map(([url, groups]) => { | ||
| // Add up the totalBootupTime for all the taskGroups | ||
| totalBootupTime += Object.keys(groups).reduce((sum, name) => sum += groups[name], 0); |
Collaborator
There was a problem hiding this comment.
@paulirish should we create an "Other" entry in the table so the total still adds up?
Contributor
There was a problem hiding this comment.
I'm in favor of "Other" unless there are better ideas
Member
There was a problem hiding this comment.
I looked into this and the table already doesn't sum to the total time displayed. the total time shown at the top includes all non-script time (layouts/paints/etc)
so if we really wanted to also capture those, we might do something like
but it's kinda wonky.
I'm in favor of skipping the "other" row(s)
Collaborator
There was a problem hiding this comment.
Alright that's fine we can skip too
Collaborator
Author
There was a problem hiding this comment.
So what's the advice here? 😋
paulirish
force-pushed
the
bug/bootup-time-10ms
branch
from
1e36cea to
366a3fc
Compare
paulirish
approved these changes
Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4220
Result:
