core(start-url): switch to plain old fetch#4301
Merged
Conversation
patrickhulce
commented
Jan 19, 2018
|
|
||
| executeFetchRequest(driver, url) { | ||
| return new Promise((resolve, reject) => { | ||
| let requestId; |
Collaborator
Author
There was a problem hiding this comment.
@wardpeet I think all this was only necessary in a previous version during review when you needed requestId IIRC, was there another reason you can remember we didn't just use evaluateAsync on fetch?
Collaborator
There was a problem hiding this comment.
I cannot recall why I needed it but my first version had exact the same fetch as you have now. I believe @brendankenny wanted to give a good error message in a follow up but besides that I don't really know why the network dance is in there.
wardpeet
approved these changes
Jan 19, 2018
paulirish
approved these changes
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4287