core(a11y): aXe perf: only collect provided resultTypes#4380
Merged
patrickhulce merged 1 commit intomasterfrom Feb 6, 2018
Merged
core(a11y): aXe perf: only collect provided resultTypes#4380patrickhulce merged 1 commit intomasterfrom
patrickhulce merged 1 commit intomasterfrom
Conversation
|
It might require you to change your score calculator if you take the exact number of passes into account. We are considering adding the count into the results structure in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new axe document on performance suggests safelisting the resultTypes you're interested in. This saves time generating unique selectors (which on mlb.com can take 4s).
cc @dylanb
This reduces about a 1 second of runtime cost of axe on mlb.com. (13s to 12s with the dequelabs/axe-core#699 PR)