tests(coverage): minimize impact of timeout due to istanbul's instrumentation#4396
Merged
tests(coverage): minimize impact of timeout due to istanbul's instrumentation#4396
Conversation
patrickhulce
approved these changes
Jan 31, 2018
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
seems fine to me!
really annoying that the only way to eliminate instrumentation is separate files, then again it might be nice to collect all our client-side run functions in a single place so it becomes clear what gets run where :)
| const url = 'chrome://version'; | ||
| const filename = path.join(process.cwd(), 'run.ts.results.json'); | ||
| const flags = getFlags(`--output=json --output-path=${filename} ${url}`); | ||
| const timeoutFlag = `--max-wait-for-load=${9000}`; |
Collaborator
There was a problem hiding this comment.
I'm curious, why put 9000 in template? :)
Member
Author
Yup totally agree. |
paulirish
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #4395 has the backstory. This PR has a few things going on:
istanbul ignorestatements. as detailed in Move any clientside JS functions to their own files #4395 they must be standalone (and spelled right).As a result of this PR,
yarn coverageshould be 36s faster, and no timeout error in the travis log. However the code coverage stats for the CLI are still incorrect and the roundtrip run is still not truly successful.This leads to a followup question: Should we have other success criteria for the run-test.js roundtrip test, like calculating TTI, etc?
Ref #4395 but doesn't close it.