core(webfonts): Patches fonts gatherer so it doesn't throw an exception#4465
Merged
patrickhulce merged 3 commits intomasterfrom Feb 8, 2018
Merged
core(webfonts): Patches fonts gatherer so it doesn't throw an exception#4465patrickhulce merged 3 commits intomasterfrom
patrickhulce merged 3 commits intomasterfrom
Conversation
wardpeet
changed the title
patrickhulce
reviewed
Feb 8, 2018
| return loadedFonts.map(fontFace => { | ||
| const fontFaceItem = this._findSameFontFamily(fontFace, fontFaces); | ||
| fontFace.src = fontFaceItem.src || []; | ||
| fontFace.src = []; |
Collaborator
There was a problem hiding this comment.
seems like we lost the case where .src is not an array but not sure if that's possible?
how abouts fontFace.src = (fontFaceItem && fontFaceItem.src) || []?
Collaborator
Author
There was a problem hiding this comment.
your wish is my command!
patrickhulce
reviewed
Feb 8, 2018
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
thanks for finding and fixing so quick @wardpeet!
patrickhulce
approved these changes
Feb 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4464