Skip to content

tests(smokehouse): improve smokehouse failure output#4482

Merged
patrickhulce merged 1 commit intomasterfrom
smokehouseoutput
Feb 9, 2018
Merged

tests(smokehouse): improve smokehouse failure output#4482
patrickhulce merged 1 commit intomasterfrom
smokehouseoutput

Conversation

@paulirish
Copy link
Member

Based on recently having to poke around the output, here's a proposal to improve the readability of failures.

Two before & after examples, taken from recent failures:

image

image

changes

  • display expected & found on top of eachother
  • switch order so found comes next to "full found result"
  • serialize objects, including regular expressions. no more [Object object]
  • formatting

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickhulce patrickhulce merged commit d8daeb3 into master Feb 9, 2018
@patrickhulce patrickhulce deleted the smokehouseoutput branch February 9, 2018 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants