core(responsive-images): move images with no dimensions to offscreen audit#4487
Merged
core(responsive-images): move images with no dimensions to offscreen audit#4487
Conversation
paulirish
requested changes
Feb 8, 2018
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
code lgtm.
i'm thinking we should keep the "Offscreen" title anyways, though. I mean, this does get into some philosophical shit:
If a pixel at 5,5
…is 0px wide and 0px tall
Is it really there?
So I feel okay with keeping a slightly more accepted term even if its not 100% semantically accurate.
wdyt
paulirish
approved these changes
Feb 9, 2018
Contributor
|
Sounds awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3508
previously, images that had dimensions of 0 were listed in both the "Properly size images" audit (uses-responsive-images) and the "Offscreen images" audit (offscreen-images).
This PR changes the name of offscreen to "Non-visible images" and "Properly size images" does not show an image if the area of the image was 0.
@midzer @tomayac @philipwalton @wardpeet does this sound good to you?