From 7ab204f10a4c13bbbe99357249957a907255c71d Mon Sep 17 00:00:00 2001 From: brandon Date: Thu, 28 Mar 2024 18:24:45 -0700 Subject: [PATCH 1/2] because users only have one set of actions, this test if run by the same user at the same time will fail. I previously tried to fix this by making detectors unique, but that won't help since actions aren't grouped by detector --- test/unit/test_actions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/unit/test_actions.py b/test/unit/test_actions.py index 399bad5d..687dcc74 100644 --- a/test/unit/test_actions.py +++ b/test/unit/test_actions.py @@ -13,6 +13,7 @@ def test_create_action(gl: ExperimentalApi): gl.get_rule(rule.id) +@pytest.mark.skip(reason="actions are global on an account, the test matrix will run multiple tests that collide") # type: ignore def test_get_all_actions(gl: ExperimentalApi): num_test_rules = 13 # needs to be larger than the default page size gl.ITEMS_PER_PAGE = 10 From 7a53a7327ee1b17c2caab090d6492914961f2914 Mon Sep 17 00:00:00 2001 From: brandon Date: Thu, 28 Mar 2024 18:28:53 -0700 Subject: [PATCH 2/2] the line was too long... --- test/unit/test_actions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/test_actions.py b/test/unit/test_actions.py index 687dcc74..c4451d10 100644 --- a/test/unit/test_actions.py +++ b/test/unit/test_actions.py @@ -13,7 +13,7 @@ def test_create_action(gl: ExperimentalApi): gl.get_rule(rule.id) -@pytest.mark.skip(reason="actions are global on an account, the test matrix will run multiple tests that collide") # type: ignore +@pytest.mark.skip(reason="actions are global on account, the test matrix collides with itself") # type: ignore def test_get_all_actions(gl: ExperimentalApi): num_test_rules = 13 # needs to be larger than the default page size gl.ITEMS_PER_PAGE = 10