From 3dfa4c9cde9c5dadd1154b7fe61cd6a6d6ece116 Mon Sep 17 00:00:00 2001
From: Javier <javidx@gmail.com>
Date: Tue, 27 Feb 2024 12:36:11 +0200
Subject: [PATCH 1/2] Added ID to global navbar to target it from other
 components Global navbar display switch to none when the user visits
 /register, which fixes issue with action bar not being responsive Applied
 lint rules to some files and deleted some commented code

---
 .../components/navbars/GlobalNavBar/index.js  |  6 ++++--
 .../register/RegistrationBottomBar/index.js   |  2 +-
 .../RegistrationSectionCustom/index.js        | 19 +++++++++----------
 .../src/pages/_events/slug/register/index.js  |  9 +++++++--
 4 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/frontend/src/components/navbars/GlobalNavBar/index.js b/frontend/src/components/navbars/GlobalNavBar/index.js
index 2bb5e6c81..cb78e8872 100644
--- a/frontend/src/components/navbars/GlobalNavBar/index.js
+++ b/frontend/src/components/navbars/GlobalNavBar/index.js
@@ -35,10 +35,12 @@ const useStyles = makeStyles(theme => ({
 export default () => {
     const classes = useStyles()
     return (
-        <div className='tw-w-full tw-py-2 tw-bg-wave-pattern ' >
+        <div
+            id="global-navbar"
+            className="tw-w-full tw-py-2 tw-bg-wave-pattern "
+        >
             <div className={classes.wrapper}>
                 <div className={classes.inner}>
-
                     <a href="/home">
                         <img
                             src={PlatformLogo}
diff --git a/frontend/src/pages/_events/slug/register/RegistrationBottomBar/index.js b/frontend/src/pages/_events/slug/register/RegistrationBottomBar/index.js
index 70e507a1a..861aedcda 100644
--- a/frontend/src/pages/_events/slug/register/RegistrationBottomBar/index.js
+++ b/frontend/src/pages/_events/slug/register/RegistrationBottomBar/index.js
@@ -47,7 +47,7 @@ const useStyles = makeStyles(theme => ({
     },
     sectionsNum: {
         color: 'white',
-        fontWeight: 'bold'
+        fontWeight: 'bold',
     },
     buttonIcon: {
         marginLeft: theme.spacing(1),
diff --git a/frontend/src/pages/_events/slug/register/RegistrationSectionCustom/index.js b/frontend/src/pages/_events/slug/register/RegistrationSectionCustom/index.js
index e5341cfdc..792b0ab68 100644
--- a/frontend/src/pages/_events/slug/register/RegistrationSectionCustom/index.js
+++ b/frontend/src/pages/_events/slug/register/RegistrationSectionCustom/index.js
@@ -47,7 +47,15 @@ const useStyles = makeStyles(theme => ({
     },
 }))
 
-export default ({ section, sectionsInfo, onNext, nextLabel, onPrev, prevLabel, data }) => {
+export default ({
+    section,
+    sectionsInfo,
+    onNext,
+    nextLabel,
+    onPrev,
+    prevLabel,
+    data,
+}) => {
     const classes = useStyles()
     const { registration } = useContext(EventDetailContext)
     console.log('section', section)
@@ -159,15 +167,6 @@ export default ({ section, sectionsInfo, onNext, nextLabel, onPrev, prevLabel, d
                                         key={question.name}
                                         className={classes.question}
                                     >
-                                        {/* <div className={classes.questionInner}>
-                                            <FastField
-                                                autoFocus={index === 0}
-                                                name={question.name}
-                                                component={RegistrationQuestion}
-                                                config={question}
-                                                isCustom={true}
-                                            />
-                                        </div> */}
                                         <div className={classes.questionInner}>
                                             <FastField name={question.name}>
                                                 {props => (
diff --git a/frontend/src/pages/_events/slug/register/index.js b/frontend/src/pages/_events/slug/register/index.js
index 8a0095e67..d22fae63b 100644
--- a/frontend/src/pages/_events/slug/register/index.js
+++ b/frontend/src/pages/_events/slug/register/index.js
@@ -146,11 +146,14 @@ export default RequiresPermission(() => {
         finishRegistration,
     } = useContext(EventDetailContext)
     const userProfile = useSelector(UserSelectors.userProfile)
-
     const [loading, setLoading] = useState(false)
     const [formData, setFormData] = useState({})
     const [activeStep, setActiveStep] = useState(0)
     const [eventNewsLetterHidden, setEventNewsLetterHidden] = useState(true)
+
+    const globalNavbarElement = document.getElementById('global-navbar')
+    globalNavbarElement.style.display = 'none'
+
     useEffect(() => {
         setTimeout(function () {
             window.scrollTo({ top: 0, left: 0, behavior: 'smooth' })
@@ -287,7 +290,9 @@ export default RequiresPermission(() => {
             }
             AnalyticsService.events.COMPLETE_REGISTRATION(slug)
             setActiveStep(sections.length + 1)
+            globalNavbarElement.style.display = 'block'
         } catch (e) {
+            globalNavbarElement.style.display = 'none'
             dispatch(
                 SnackbarActions.error(
                     'Oops, something went wrong... Please try again',
@@ -350,7 +355,7 @@ export default RequiresPermission(() => {
                                 sectionsInfo={{
                                     sections: sections.length,
                                     activeSection: index + 1,
-                                }}    
+                                }}
                                 label={section.label}
                                 fields={section.fields}
                                 onPrev={setPrevStep}

From 0cdf4063759aca145d337bde5cebae43bc561155 Mon Sep 17 00:00:00 2001
From: Javier <javidx@gmail.com>
Date: Tue, 27 Feb 2024 12:46:17 +0200
Subject: [PATCH 2/2] Modified sectionsInfo to be DRY on register/index

---
 .../src/pages/_events/slug/register/index.js    | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/frontend/src/pages/_events/slug/register/index.js b/frontend/src/pages/_events/slug/register/index.js
index d22fae63b..fcac225e1 100644
--- a/frontend/src/pages/_events/slug/register/index.js
+++ b/frontend/src/pages/_events/slug/register/index.js
@@ -238,6 +238,13 @@ export default RequiresPermission(() => {
         return sorted.concat(event?.customQuestions ?? [])
     }, [event])
 
+    const sectionsInfo = (sections, index) => {
+        return {
+            sections: sections.length,
+            activeSection: index + 1,
+        }
+    }
+
     const setNextStep = useCallback(
         (nextStep, values, path) => {
             const newFormData = path
@@ -337,10 +344,7 @@ export default RequiresPermission(() => {
                                 isActive={activeStep === index}
                                 section={section}
                                 data={formData}
-                                sectionsInfo={{
-                                    sections: sections.length,
-                                    activeSection: index + 1,
-                                }}
+                                sectionsInfo={sectionsInfo(sections, index)}
                                 onPrev={setPrevStep}
                                 prevLabel={prevStep ? prevStep.label : null}
                                 onNext={(values, path) => {
@@ -352,10 +356,7 @@ export default RequiresPermission(() => {
                             <RegistrationSection
                                 isActive={activeStep === index}
                                 data={formData}
-                                sectionsInfo={{
-                                    sections: sections.length,
-                                    activeSection: index + 1,
-                                }}
+                                sectionsInfo={sectionsInfo(sections, index)}
                                 label={section.label}
                                 fields={section.fields}
                                 onPrev={setPrevStep}