From ff4168dd59b32ccef4271d108f8c9bcbd4d88f07 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Tue, 13 Apr 2021 16:39:53 -0700 Subject: [PATCH 01/25] DisableUnrollLoops should ignore DisableLLVMLoopOpt for PTX It's not entirely clear why, but setting the `DisableUnrollLoops` flag to `true` in the PTX backend can produce Cuda code that will fail at runtime, at least for certain drivers (e.g.: some of the tests in correctness_gpu_dynamic_shared when running under NVidia v460.x). --- src/CodeGen_PTX_Dev.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/CodeGen_PTX_Dev.cpp b/src/CodeGen_PTX_Dev.cpp index 3b354e51e342..e9902b025b68 100644 --- a/src/CodeGen_PTX_Dev.cpp +++ b/src/CodeGen_PTX_Dev.cpp @@ -687,7 +687,11 @@ vector CodeGen_PTX_Dev::compile_to_src() { b.Inliner = createFunctionInliningPass(b.OptLevel, 0, false); b.LoopVectorize = do_loop_opt; b.SLPVectorize = true; - b.DisableUnrollLoops = !do_loop_opt; + // Setting DisableUnrollLoops = true can occasionally generate PTX code that + // will fail at runtime under some conditions (e.g. correctness_gpu_dynamic_shared + // using NVidia driver 460.x). Note that the (current) default value for this flag + // is `false`, so this setting is somewhat redundant. + b.DisableUnrollLoops = false; // !do_loop_opt; target_machine->adjustPassManager(b); From 1100af30dc2e87e262f73f408286ffbbb07e8b56 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:13:57 -0700 Subject: [PATCH 02/25] trigger buildbots From 3a8e30d539ff2472a1e283a63648105f7e7be1c4 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:15:23 -0700 Subject: [PATCH 03/25] trigger buildbots From d14d8569882e14dd1f6afa18f5924c8cc515e08a Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:19:59 -0700 Subject: [PATCH 04/25] trigger buildbots From 5839472850b91bf94120efcf6aaf527a906e0463 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:25:22 -0700 Subject: [PATCH 05/25] trigger buildbots From 3fe7d2374c343fc86d104597a3e34b5055b96a03 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:32:27 -0700 Subject: [PATCH 06/25] trigger buildbots From de242957315e2995e4494b774ffdf3c81079d279 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:34:29 -0700 Subject: [PATCH 07/25] trigger buildbots From 29c0d258f40f0ffcdd580530ded68fb8160b29d4 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:35:10 -0700 Subject: [PATCH 08/25] trigger buildbots From d3b0c5bc5653ca14a0017c0117ea0cfd30d00345 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:45:30 -0700 Subject: [PATCH 09/25] trigger buildbots From 17110d77da817f5aa8fc84fcbb539ef214209c1a Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:49:39 -0700 Subject: [PATCH 10/25] trigger buildbots From 5e0571c79e13cea8c75b183f1f737a63ce63c1da Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:53:34 -0700 Subject: [PATCH 11/25] trigger buildbots From d0cc79707163e087c63ba4456e9fc8ea5b322e0d Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 16:58:19 -0700 Subject: [PATCH 12/25] trigger buildbots From be85109f9d9972678b436c63853f97b5fcfdc0f1 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 17:00:42 -0700 Subject: [PATCH 13/25] trigger buildbots From e7ad0c2682b3f4361f7e164a3e46792f42429bb8 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 17:08:17 -0700 Subject: [PATCH 14/25] trigger buildbots From b6856104485bddb71bb91e209d6aaaae655de8b9 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 17:11:06 -0700 Subject: [PATCH 15/25] trigger buildbots From 042d5fc45d60228eb9669f6970cb9cde53329c2b Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 17:19:26 -0700 Subject: [PATCH 16/25] trigger buildbots From 18c82a83eabe33d40500f2983076f14e8f5cc4a9 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 18:01:53 -0700 Subject: [PATCH 17/25] trigger buildbots From b494d431713beed90d71f46cb0571c0ec5faf3e3 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 18:02:48 -0700 Subject: [PATCH 18/25] trigger buildbots From 2d8c87c3c253297879b961eac3cfdc2418b73cc4 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Fri, 14 May 2021 18:24:33 -0700 Subject: [PATCH 19/25] trigger buildbots From 0437493502777bf81eb5d248e4f5a19211ae3922 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Sun, 16 May 2021 14:02:31 -0700 Subject: [PATCH 20/25] trigger buildbots From 910330eb97ea38dec34adefffad9bdde28c9f5d8 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Sun, 16 May 2021 14:06:59 -0700 Subject: [PATCH 21/25] trigger buildbots From 6e8182bf179c4b5d2b01140c52622a3ed9872f26 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Sun, 16 May 2021 14:10:20 -0700 Subject: [PATCH 22/25] trigger buildbots From ad8ccfd4d844d8221005efcb761dc5c04057fe7d Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Sun, 16 May 2021 14:10:53 -0700 Subject: [PATCH 23/25] trigger buildbots From ea105131d11efdf937aebf6aedabfee05b99fda7 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Sun, 16 May 2021 14:13:58 -0700 Subject: [PATCH 24/25] trigger buildbots From e72f230e1cda7ee7310f3fd99a7fde10dadd84e4 Mon Sep 17 00:00:00 2001 From: Steven Johnson Date: Sun, 16 May 2021 14:28:42 -0700 Subject: [PATCH 25/25] trigger buildbots