From e4bcc47d621e7946d7fc2d38132555239e5079c1 Mon Sep 17 00:00:00 2001
From: longjuan <769022681@qq.com>
Date: Fri, 19 Jul 2024 22:39:06 +0800
Subject: [PATCH 1/4] feat: support selecting groups to join when link

---
 console/src/api/models/link-request.ts        |  6 ++
 console/src/views/S3Link.vue                  | 78 +++++++++++++++++--
 src/main/java/run/halo/s3os/LinkRequest.java  |  1 +
 .../java/run/halo/s3os/S3LinkController.java  |  2 +-
 .../java/run/halo/s3os/S3LinkService.java     |  8 +-
 .../java/run/halo/s3os/S3LinkServiceImpl.java | 14 ++--
 6 files changed, 95 insertions(+), 14 deletions(-)

diff --git a/console/src/api/models/link-request.ts b/console/src/api/models/link-request.ts
index d9bc67c..60d85fd 100644
--- a/console/src/api/models/link-request.ts
+++ b/console/src/api/models/link-request.ts
@@ -20,6 +20,12 @@
  * @interface LinkRequest
  */
 export interface LinkRequest {
+    /**
+     * 
+     * @type {string}
+     * @memberof LinkRequest
+     */
+    'groupName'?: string;
     /**
      * 
      * @type {Array<string>}
diff --git a/console/src/views/S3Link.vue b/console/src/views/S3Link.vue
index 15a577f..8bbe479 100644
--- a/console/src/views/S3Link.vue
+++ b/console/src/views/S3Link.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
-import { computed, onMounted, ref, watch } from "vue";
+import { computed, getCurrentInstance, onMounted, ref, watch } from "vue";
 import {
+  IconCheckboxCircle,
   IconRefreshLine,
   Toast,
   VButton,
@@ -16,21 +17,42 @@ import {
 } from "@halo-dev/components";
 import CarbonFolderDetailsReference from "~icons/carbon/folder-details-reference";
 import IconErrorWarning from "~icons/ri/error-warning-line";
-import { axiosInstance } from "@halo-dev/api-client";
+import { axiosInstance, coreApiClient, type Group } from "@halo-dev/api-client";
 import { S3LinkControllerApi } from "@/api";
 import type { S3ListResult, LinkResultItem, Policy, ObjectVo } from "@/api";
 
 const s3LinkControllerApi = new S3LinkControllerApi(undefined, axiosInstance.defaults.baseURL, axiosInstance);
 
+const componentInstance = getCurrentInstance();
+const t = (key: string) => {
+  // @ts-ignore
+  if (typeof componentInstance?.proxy?.$t === 'function') {
+    // @ts-ignore
+    return componentInstance.proxy.$t(key);
+  }
+  return key;
+};
+
 const selectedFiles = ref<string[]>([]);
 const policyName = ref<string>("");
 const page = ref(1);
 const size = ref(50);
+const selectedGroup = ref("")
 const policyOptions = ref<{ label: string; value: string; attrs: any }[]>([{
   label: "请选择存储策略",
   value: "",
   attrs: {disabled: true}
 }]);
+const defaultGroup = ref<Group>({
+  apiVersion: "",
+  kind: "",
+  metadata: {
+    name: "",
+  },
+  spec: {
+    displayName: t("core.attachment.common.text.ungrouped"),
+  },
+});
 // update when fetch first page
 const filePrefix = ref<string>("");
 // update when user input
@@ -43,6 +65,7 @@ const s3Objects = ref<S3ListResult>({
   currentContinuationObject: "",
   nextContinuationObject: "",
 });
+const customGroups = ref<Group[]>([]);
 // view state
 const isFetching = ref(false);
 const isShowModal = ref(false);
@@ -91,7 +114,7 @@ const handleCheckAllChange = (e: Event) => {
 const fetchPolicies = async () => {
   try {
     const {status, data} = await s3LinkControllerApi.listS3Policies();
-    if (status == 200) {
+    if (status === 200) {
       policyOptions.value = [{
         label: "请选择存储策略",
         value: "",
@@ -174,7 +197,8 @@ const handleLink = async () => {
   const linkResult = await s3LinkControllerApi.addAttachmentRecord({
     linkRequest: {
       policyName: policyName.value,
-      objectKeys: selectedFiles.value
+      objectKeys: selectedFiles.value,
+      groupName: selectedGroup.value,
     }
   });
   const items = linkResult.data.items || [];
@@ -219,7 +243,20 @@ const handleModalClose = () => {
   fetchObjects();
 };
 
-onMounted(fetchPolicies);
+const fetchCustomGroups = async () => {
+  const {status, data} = await coreApiClient.storage.group.listGroup({
+    labelSelector: ["!halo.run/hidden"],
+    sort: ["metadata.creationTimestamp,asc"],
+  });
+  if (status === 200) {
+    customGroups.value = data.items;
+  }
+};
+
+onMounted(() => {
+  fetchPolicies();
+  fetchCustomGroups();
+});
 
 watch(selectedFiles, (newValue) => {
   checkedAll.value = s3Objects.value.objects?.filter(file => !file.isLinked)
@@ -327,6 +364,37 @@ watch(selectedLinkedStatusItem, handleFirstPage);
           class="box-border h-full w-full divide-y divide-gray-100"
           role="list"
         >
+          <li style="padding: 8px 16px 0;">
+            <span class="ml-1 mb-1 block text-sm text-gray-500">关联后所加入的分组</span>
+            <div class="mb-5 grid grid-cols-2 gap-x-2 gap-y-3 md:grid-cols-3 lg:grid-cols-4 2xl:grid-cols-6">
+              <button
+                type="button"
+                class="inline-flex h-full w-full items-center gap-2 rounded-md border border-gray-200 bg-white px-3 py-2.5 text-sm font-medium text-gray-800 hover:bg-gray-50 hover:shadow-sm"
+                v-for="(group, index) in [defaultGroup, ...customGroups]"
+                :key="index"
+                :class="{ '!bg-gray-100 shadow-sm': group.metadata.name === selectedGroup }"
+                @click="selectedGroup = group.metadata.name"
+              >
+                <div class="inline-flex w-full flex-1 gap-x-2 break-all text-left">
+                  <slot name="text">
+                    {{ group?.spec.displayName }}
+                  </slot>
+                  <VStatusDot
+                    v-if="group?.metadata.deletionTimestamp"
+                    v-tooltip="$t('core.common.status.deleting')"
+                    state="warning"
+                    animate
+                  />
+                </div>
+                <div class="flex-none">
+                  <IconCheckboxCircle
+                    v-if="group.metadata.name === selectedGroup"
+                    class="text-primary"
+                  />
+                </div>
+              </button>
+            </div>
+          </li>
           <li v-for="(file, index) in s3Objects.objects" :key="index">
             <VEntity :is-selected="checkSelection(file)">
               <template
diff --git a/src/main/java/run/halo/s3os/LinkRequest.java b/src/main/java/run/halo/s3os/LinkRequest.java
index ee73edf..b6990f7 100644
--- a/src/main/java/run/halo/s3os/LinkRequest.java
+++ b/src/main/java/run/halo/s3os/LinkRequest.java
@@ -9,4 +9,5 @@
 public class LinkRequest {
     private String policyName;
     private Set<String> objectKeys;
+    private String groupName;
 }
\ No newline at end of file
diff --git a/src/main/java/run/halo/s3os/S3LinkController.java b/src/main/java/run/halo/s3os/S3LinkController.java
index 0baa5ee..23b9145 100644
--- a/src/main/java/run/halo/s3os/S3LinkController.java
+++ b/src/main/java/run/halo/s3os/S3LinkController.java
@@ -41,6 +41,6 @@ public Mono<S3ListResult> listObjects(@PathVariable(value = "policyName") String
     @PostMapping("/attachments/link")
     public Mono<LinkResult> addAttachmentRecord(@RequestBody LinkRequest linkRequest) {
         return s3LinkService.addAttachmentRecords(linkRequest.getPolicyName(),
-            linkRequest.getObjectKeys());
+            linkRequest.getObjectKeys(), linkRequest.getGroupName());
     }
 }
diff --git a/src/main/java/run/halo/s3os/S3LinkService.java b/src/main/java/run/halo/s3os/S3LinkService.java
index 2a1bb45..ce38620 100644
--- a/src/main/java/run/halo/s3os/S3LinkService.java
+++ b/src/main/java/run/halo/s3os/S3LinkService.java
@@ -10,10 +10,12 @@ public interface S3LinkService {
     Flux<Policy> listS3Policies();
 
     Mono<S3ListResult> listObjects(String policyName, String continuationToken,
-        Integer pageSize, String filePrefix);
+                                   Integer pageSize, String filePrefix);
 
-    Mono<LinkResult> addAttachmentRecords(String policyName, Set<String> objectKeys);
+    Mono<LinkResult> addAttachmentRecords(String policyName, Set<String> objectKeys,
+                                          String groupName);
 
     Mono<S3ListResult> listObjectsUnlinked(String policyName, String continuationToken,
-        String continuationObject, Integer pageSize, String filePrefix);
+                                           String continuationObject, Integer pageSize,
+                                           String filePrefix);
 }
diff --git a/src/main/java/run/halo/s3os/S3LinkServiceImpl.java b/src/main/java/run/halo/s3os/S3LinkServiceImpl.java
index cd3cf27..ba6b6d1 100644
--- a/src/main/java/run/halo/s3os/S3LinkServiceImpl.java
+++ b/src/main/java/run/halo/s3os/S3LinkServiceImpl.java
@@ -113,11 +113,11 @@ public Mono<S3ListResult> listObjects(String policyName, String continuationToke
     }
 
     @Override
-    public Mono<LinkResult> addAttachmentRecords(String policyName, Set<String> objectKeys) {
+    public Mono<LinkResult> addAttachmentRecords(String policyName, Set<String> objectKeys, String groupName) {
         return getOperableObjectKeys(objectKeys, policyName)
             .flatMap(operableObjectKeys -> getExistingAttachments(objectKeys, policyName)
                 .flatMap(existingAttachments -> getLinkResultItems(objectKeys, operableObjectKeys,
-                    existingAttachments, policyName)
+                    existingAttachments, policyName, groupName)
                     .collectList()
                     .map(LinkResult::new)));
     }
@@ -147,12 +147,13 @@ private Mono<Set<String>> getExistingAttachments(Set<String> objectKeys,
     private Flux<LinkResult.LinkResultItem> getLinkResultItems(Set<String> objectKeys,
                                                                Set<String> operableObjectKeys,
                                                                Set<String> existingAttachments,
-                                                               String policyName) {
+                                                               String policyName,
+                                                               String groupName) {
         return Flux.fromIterable(objectKeys)
             .flatMap((objectKey) -> {
                 if (operableObjectKeys.contains(objectKey) &&
                     !existingAttachments.contains(objectKey)) {
-                    return addAttachmentRecord(policyName, objectKey)
+                    return addAttachmentRecord(policyName, objectKey, groupName)
                         .onErrorResume((throwable) -> Mono.just(
                             new LinkResult.LinkResultItem(objectKey, false,
                                 throwable.getMessage())));
@@ -223,7 +224,7 @@ record TokenState(String currToken, String nextToken) {
     }
 
     public Mono<LinkResult.LinkResultItem> addAttachmentRecord(String policyName,
-        String objectKey) {
+        String objectKey, String groupName) {
         return authenticationConsumer(authentication -> client.fetch(Policy.class, policyName)
             .flatMap((policy) -> {
                 var configMapName = policy.getSpec().getConfigMapName();
@@ -255,6 +256,9 @@ public Mono<LinkResult.LinkResultItem> addAttachmentRecord(String policyName,
                         }
                         spec.setOwnerName(authentication.getName());
                         spec.setPolicyName(policyName);
+                        if (StringUtils.isNotBlank(groupName)){
+                            spec.setGroupName(groupName);
+                        }
                     })
                     .flatMap(client::create)
                     .thenReturn(new LinkResult.LinkResultItem(objectKey, true, null));

From e73ed5a492ead947a58510123d9b29cf7e46d590 Mon Sep 17 00:00:00 2001
From: longjuan <769022681@qq.com>
Date: Fri, 19 Jul 2024 22:42:58 +0800
Subject: [PATCH 2/4] remove Beta label from S3 link feature

---
 console/src/views/S3Link.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/console/src/views/S3Link.vue b/console/src/views/S3Link.vue
index 8bbe479..926b22b 100644
--- a/console/src/views/S3Link.vue
+++ b/console/src/views/S3Link.vue
@@ -269,7 +269,7 @@ watch(selectedLinkedStatusItem, handleFirstPage);
 </script>
 
 <template>
-  <VPageHeader title="关联S3文件(Beta)">
+  <VPageHeader title="关联S3文件">
     <template #icon>
       <CarbonFolderDetailsReference class="mr-2 self-center"/>
     </template>

From 0402c9aa58777e45e1c7e53a3897c3d2766744ac Mon Sep 17 00:00:00 2001
From: longjuan <769022681@qq.com>
Date: Fri, 19 Jul 2024 22:44:52 +0800
Subject: [PATCH 3/4] add VStatusDot component to S3Link.vue

---
 console/src/views/S3Link.vue | 1 +
 1 file changed, 1 insertion(+)

diff --git a/console/src/views/S3Link.vue b/console/src/views/S3Link.vue
index 926b22b..b5ba9ec 100644
--- a/console/src/views/S3Link.vue
+++ b/console/src/views/S3Link.vue
@@ -13,6 +13,7 @@ import {
   VModal,
   VPageHeader,
   VSpace,
+  VStatusDot,
   VTag,
 } from "@halo-dev/components";
 import CarbonFolderDetailsReference from "~icons/carbon/folder-details-reference";

From df41ad7346f4aa7124f48d227381a7e1968b4c39 Mon Sep 17 00:00:00 2001
From: longjuan <769022681@qq.com>
Date: Fri, 19 Jul 2024 22:50:27 +0800
Subject: [PATCH 4/4] adjust padding on list items for better readability

---
 console/src/views/S3Link.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/console/src/views/S3Link.vue b/console/src/views/S3Link.vue
index b5ba9ec..e0c6027 100644
--- a/console/src/views/S3Link.vue
+++ b/console/src/views/S3Link.vue
@@ -365,7 +365,7 @@ watch(selectedLinkedStatusItem, handleFirstPage);
           class="box-border h-full w-full divide-y divide-gray-100"
           role="list"
         >
-          <li style="padding: 8px 16px 0;">
+          <li style="padding: 0.5rem 1rem 0">
             <span class="ml-1 mb-1 block text-sm text-gray-500">关联后所加入的分组</span>
             <div class="mb-5 grid grid-cols-2 gap-x-2 gap-y-3 md:grid-cols-3 lg:grid-cols-4 2xl:grid-cols-6">
               <button