From 822e0617675c18ed8d639688311c8aba6887fa9b Mon Sep 17 00:00:00 2001 From: Juneil Date: Wed, 14 Mar 2018 14:58:14 +0100 Subject: [PATCH 1/2] feat(socket): store --- package.json | 2 +- src/extensions/socket-server/socket.ts | 11 +++++++++++ test/integration/socket-server-rooms.test.ts | 2 ++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 3155b85..d98eb63 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@hapiness/core", - "version": "1.3.1", + "version": "1.3.2", "description": "Project to have a HapiJS (https://hapijs.com/) based framework to create easier NodeJS back-end with some awesome features", "main": "commonjs/index.js", "types": "index.d.ts", diff --git a/src/extensions/socket-server/socket.ts b/src/extensions/socket-server/socket.ts index 36d6bda..86e4395 100644 --- a/src/extensions/socket-server/socket.ts +++ b/src/extensions/socket-server/socket.ts @@ -14,6 +14,8 @@ export class Socket { private data$ = new Subject(); + private store: { [key: string]: any } = {}; + constructor( private _request: request, private _connection: connection, @@ -128,6 +130,15 @@ export class Socket { return this; } + set(key: string, value: any): Socket { + this.store[key] = value; + return this; + } + + get(key: string): any { + return this.store[key]; + } + private getJSON(data: string) { try { return JSON.parse(data); diff --git a/test/integration/socket-server-rooms.test.ts b/test/integration/socket-server-rooms.test.ts index 51ea41b..964d552 100644 --- a/test/integration/socket-server-rooms.test.ts +++ b/test/integration/socket-server-rooms.test.ts @@ -26,6 +26,7 @@ export class SocketServerRoomIntegration { socket => { unit.array(this.server.instance().getSockets()) .hasLength(1); + socket.set('test', 123); socket .join('room1') .join('room2'); @@ -34,6 +35,7 @@ export class SocketServerRoomIntegration { socket.on('tata', data => {}); socket.on('*', data => { unit.string(data.utf8Data).is('received'); + unit.value(socket.get('test').is(123)); socket.close(); this .server From cd9403edaf049103b527dae8a03fe9f6a97efb9e Mon Sep 17 00:00:00 2001 From: Juneil Date: Wed, 14 Mar 2018 15:13:49 +0100 Subject: [PATCH 2/2] fix(test) --- src/extensions/socket-server/socket.ts | 4 ++-- test/integration/socket-server-rooms.test.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/extensions/socket-server/socket.ts b/src/extensions/socket-server/socket.ts index 86e4395..2b6c913 100644 --- a/src/extensions/socket-server/socket.ts +++ b/src/extensions/socket-server/socket.ts @@ -130,12 +130,12 @@ export class Socket { return this; } - set(key: string, value: any): Socket { + setData(key: string, value: any): Socket { this.store[key] = value; return this; } - get(key: string): any { + getData(key: string): any { return this.store[key]; } diff --git a/test/integration/socket-server-rooms.test.ts b/test/integration/socket-server-rooms.test.ts index 964d552..a511c9a 100644 --- a/test/integration/socket-server-rooms.test.ts +++ b/test/integration/socket-server-rooms.test.ts @@ -26,7 +26,7 @@ export class SocketServerRoomIntegration { socket => { unit.array(this.server.instance().getSockets()) .hasLength(1); - socket.set('test', 123); + socket.setData('test', 123); socket .join('room1') .join('room2'); @@ -35,7 +35,7 @@ export class SocketServerRoomIntegration { socket.on('tata', data => {}); socket.on('*', data => { unit.string(data.utf8Data).is('received'); - unit.value(socket.get('test').is(123)); + unit.value(socket.getData('test')).is(123); socket.close(); this .server